Add custom k_diffusion scheduler in settings

[KohakuBlueleaf]

Based on #10634, use settings instead of add new things in main interface.
Recommend to use with #10648

[KohakuBlueleaf]

@catboxanon Now I also have settings version

[catboxanon]

You shouldn't need to modify the function signature of StableDiffusionProcessing and add those variables to the class -- take a look at how other parameters like CLIP skip are handled.

[KohakuBlueleaf]

You shouldn't need to modify the function signature of StableDiffusionProcessing and add those variables to the class -- take a look at how other parameters like CLIP skip are handled.

Oh I just take how s_tmax and s_churn works...
So these thing also should not work like that?

[catboxanon]

That's a fair point. I think those are artifacts of being there from the nearly the very beginning. To me it makes more sense for anything additional like this to be thrown into extra_generation_params, similar to how the CFG rescale parameter is handled in it's PR. https://github.com/AUTOMATIC1111/stable-diffusion-webui/pull/10555/files

[KohakuBlueleaf]

@catboxanon I use extra parameters now.
It looks more clean(?)

[catboxanon]

Looks better -- be sure to update the xyz script by using apply_override instead too.

[KohakuBlueleaf]

Looks better -- be sure to update the xyz script by using apply_override instead too.

oh yes I forgot it

[catboxanon]

I think now that these parameters are moved into settings and no longer have an associated UI, adding the VP scheduler and it's associated settings (if we want to expose these) should be trivial to do now. The custom_k_sched option could also be replaced by adding an option of Automatic or similar to the schedule list that will fallback to default behavior and be the set option by default, which would also make xyz plot usage simpler (no need to enable something extra in settings then).

[KohakuBlueleaf]

@catboxanon done!

[catboxanon]

None and/or default aren't really correct (a scheduler has to be used, and the default is only used for non-Karras samplers), which is why I think it should be renamed to Automatic, and is consistent with how the sd_vae and cross_attention_optimization settings are handled.

[KohakuBlueleaf]

None and/or default aren't really correct (a scheduler has to be used, and the default is only used for non-Karras samplers), which is why I think it should be renamed to Automatic, and is consistent with how the sd_vae and cross_attention_optimization settings are handled.

ok

[AUTOMATIC1111]

I have some changes that I have in mind for this:

• shorter names for infotext fields
• do not add infotext fields when their value is the default (which would require the default values to be added in parse_generation_parameters)
• use actual sigma_max value in UI as default (it's 14.something)
• add fields to p.extra_generation_params in the very same place where they are added to sigmas_kwargs rather than in a different function

If you feel like it, you can add any of those into PR, otherwise I'll just merge this later when I have time to implement and test them.

[KohakuBlueleaf]

I have some changes that I have in mind for this:

• shorter names for infotext fields
• do not add infotext fields when their value is the default (which would require the default values to be added in parse_generation_parameters)
• use actual sigma_max value in UI as default (it's 14.something)
• add fields to p.extra_generation_params in the very same place where they are added to sigmas_kwargs rather than in a different function

If you feel like it, you can add any of those into PR, otherwise I'll just merge this later when I have time to implement and test them.

I will do:

1. change "KDiffusion Scheduler xxx" to "KDiff Sched xxx", which will be shorter than other 3~5 longest names so I think it is acceptable.
2. combine 2 and 4, add extra parameter only if use non-default value.
3. use min=0.3 and max=14.6 as default value, which is the default value for SD models. But still take 0.0 as model default. (It is possible that some model will change their beta/alpha schedule, so the "default sigma" will be different from original SD)

[KohakuBlueleaf]

ok I think "Sched" may not be good.
I will use KDiff Schedule instead. If this is not short enough. You can just change it afterward.

[KohakuBlueleaf]

@AUTOMATIC1111 I think for now it is better?