[fix] can't load webui if selected wrong extra option in ui #15120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a bug: you can add an option from extension, e.g.
controlnet_show_batch_images_in_ui
, and after restart webui won't able to start, due to KeyError. It happens because this option was declared inon_ui_settings
callback. I've found the solution, if the author of extension wants to be able to add their option in settings in ui, they need to use option template instead of callback, like w-e-w does in their nudenet_nsfw_censor_scripts/settings.py (fix in my extension: light-and-ray/sd-webui-lama-cleaner-masked-content@e8a9170) Maybe it's needed to add recommendation to not useon_ui_settings
callbackMy PR fixes 2 things:
create_ui
momentChecklist: