Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[alternative fix] can't load webui if selected wrong extra option in ui #15121

Merged
merged 1 commit into from
Mar 4, 2024
Merged

[alternative fix] can't load webui if selected wrong extra option in ui #15121

merged 1 commit into from
Mar 4, 2024
+12 −4

Conversation

AUTOMATIC1111
Copy link
Owner

Description

Alternative fix for #15120

@AUTOMATIC1111
call script_callbacks.ui_settings_callback earlier; fix extra-options…
0dc1286 
…-section built-in extension killing the ui if using a setting that doesn't exist
@AUTOMATIC1111 AUTOMATIC1111 mentioned this pull request Mar 4, 2024
Closed
4 tasks
light-and-ray
light-and-ray approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@light-and-ray light-and-ray left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it works for me. I thought these callbacks are in gradio context, but nope, they are outside

I swear there was a option to disable cn while hires fix. About a half year ago I wanted to add it, but faced with the bug. 🤨 Where is this option now

@AUTOMATIC1111 AUTOMATIC1111 merged commit 58278aa into dev Mar 4, 2024
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the fix-settings-in-ui branch March 4, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@light-and-ray light-and-ray light-and-ray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AUTOMATIC1111 @noisefloordev @light-and-ray