News #803
Merged
News #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/fi/aalto/cs/apluscourses/intellij/actions/OpenItemAction.java # src/main/java/fi/aalto/cs/apluscourses/intellij/toolwindows/APlusToolWindowFactory.java # src/main/java/fi/aalto/cs/apluscourses/intellij/utils/Interfaces.java # src/main/java/fi/aalto/cs/apluscourses/presentation/MainViewModel.java # src/main/java/fi/aalto/cs/apluscourses/ui/CollapsibleSplitter.java # src/main/resources/resources.properties
# Conflicts: # src/main/java/fi/aalto/cs/apluscourses/intellij/model/CourseUpdater.java # src/main/java/fi/aalto/cs/apluscourses/intellij/toolwindows/APlusToolWindowFactory.java
# Conflicts: # src/main/java/fi/aalto/cs/apluscourses/intellij/model/CourseUpdater.java # src/main/java/fi/aalto/cs/apluscourses/intellij/toolwindows/APlusToolWindowFactory.java
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
Taikelenn
requested changes
Nov 17, 2021
Comment on lines
-76
to
+77
| presentation.userDropdown.notLoggedIn=Not logged in | ||
| presentation.userDropdown.loggedInAs=Logged in as {0} | ||
| presentation.userDropdown.notLoggedIn=Not Logged In | ||
| presentation.userDropdown.loggedInAs=Logged In As {0} |
OlliKiljunen
approved these changes
Nov 17, 2021
| @@ -27,6 +27,7 @@ repositories { | |||
| } | |||
|
|
|||
| dependencies { | |||
| implementation 'org.jsoup:jsoup:1.14.3' | |||
There was a problem hiding this comment.
Did you consider other alternatives? Anyway, this looks like a good choice.
There was a problem hiding this comment.
I read some comparisons online and this seemed like the best choice
|
|
||
| public class OpenItemAction extends DumbAwareAction { | ||
| public class OpenItemAction<T> extends DumbAwareAction { |
Comment on lines
36
to
37
| newsViewModel.getModel().getNews().forEach(News::setRead); | ||
| mainViewModel.newsTreeViewModel.valueChanged(); |
There was a problem hiding this comment.
Nit: This logic could perhaps be in the model.
Comment on lines
106
to
107
| return readNews.getReadNews() != null | ||
| && Arrays.stream(readNews.getReadNews().split(";")).anyMatch(idS -> Long.parseLong(idS) == this.id); |
There was a problem hiding this comment.
Nit: Store the array in a variable instead of getting it twice.
| @NotNull Options options) { | ||
| @Nullable Options options) { |
There was a problem hiding this comment.
Did you consider using some kind of "allGoesOptions" instead of making this nullable? That way some null checks below could perhaps have been avoided.
|
|
||
| @NotNull | ||
| public String getTitle() { | ||
| var unread = getModel().getNews().stream().filter(news -> !news.isRead()).count(); |
There was a problem hiding this comment.
NitL This logic would be better in the model.
…nges # Conflicts: # src/main/java/fi/aalto/cs/apluscourses/intellij/utils/Interfaces.java # src/test/java/fi/aalto/cs/apluscourses/intellij/model/CourseUpdaterTest.java
…nges # Conflicts: # src/main/java/fi/aalto/cs/apluscourses/intellij/utils/Interfaces.java # src/test/java/fi/aalto/cs/apluscourses/intellij/model/CourseUpdaterTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
Testing
Have you updated the TESTING.md or other relevant documentation on your branch?