#7: Move the code from atum-service into this repository #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benedeki
added
the
work in progress
Co-authored-by: miroslavpojer <miroslav.pojer@absa.africa>
Do we need/expect integration tests for this support library? 🤔 |
Only write it down to be part of design process. Integration test will each usage of this library for test creation. |
|
See related PR - adding support of JaCoCo - #12. |
benedeki
removed
the
work in progress
lsulak
reviewed
Dec 6, 2023
|
|
||
| package object implicits { | ||
|
|
||
| implicit def tableOwnerConnection(in: DBConnection): Connection = in.connection |
There was a problem hiding this comment.
I don't understand this name. I think it's too context specific, but what this does it just an implicit conversion from one type of DB connection to another one
lsulak
reviewed
Dec 6, 2023
| * @param params - the list of parameters | ||
| */ | ||
| sealed abstract class DBFunction private(functionName: String, | ||
| params: ListMap[Either[Int, String], SetterFnc]) extends DBQuerySupport { |
There was a problem hiding this comment.
Suggested change
| params: ListMap[Either[Int, String], SetterFnc]) extends DBQuerySupport { | |
| params: ParamsMap) extends DBQuerySupport { |
you also need to import ParamsMap so that it's visible in this scope
lsulak
reviewed
Dec 6, 2023
lsulak
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transfer of the code from Atum repo PR
Closes #7