Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#11: Introduce code coverage measuring by JaCoCo #12

Merged
merged 12 commits into from
Sep 29, 2024
Merged

#11: Introduce code coverage measuring by JaCoCo #12

merged 12 commits into from
Sep 29, 2024

Conversation

miroslavpojer
Copy link
Collaborator

@miroslavpojer miroslavpojer commented Nov 24, 2023 •
edited by benedeki
Loading

JaCoCo introduced into project.

Closes #11

@miroslavpojer miroslavpojer self-assigned this Nov 24, 2023
@miroslavpojer miroslavpojer mentioned this pull request Nov 24, 2023
Merged
miroslavpojer
miroslavpojer commented Nov 27, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@miroslavpojer
Update .gitignore
ef20c13 
Updated year.
@benedeki benedeki added the dependent The item depends on some other open item (Issue or PR) label Nov 29, 2023
lsulak
lsulak reviewed Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@lsulak lsulak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to document some usages / supported types etc into README, but otherwise really good work, I like the Either approach you chose, apart from many other things :)

@lsulak
Copy link
Collaborator

lsulak commented Dec 6, 2023 •
edited
Loading

Oh wait a minute, this is almost an exact copy of https://github.com/AbsaOSS/balta/pull/10/files. I propose to repoint this PR to that branch then, not to master.

@benedeki
Copy link
Contributor

benedeki commented Dec 6, 2023

Oh wait a minute, this is almost an exact copy of https://github.com/AbsaOSS/balta/pull/10/files. I propose to repoint this PR to that branch then, not to master.

Yeah, @miroslavpojer took my branch, added JaCoco support and created a PR. But directed it to master which I kind of missed. Therefore it's confusing.

@miroslavpojer
Copy link
Collaborator Author

Oh wait a minute, this is almost an exact copy of https://github.com/AbsaOSS/balta/pull/10/files. I propose to repoint this PR to that branch then, not to master.

Yeah, @miroslavpojer took my branch, added JaCoco support and created a PR. But directed it to master which I kind of missed. Therefore it's confusing.

Hi, sorry for that. I have repointed it to from master.

@miroslavpojer
Merge branch 'feature/7-move-the-code-from-atum-service-into-this-rep…
c904ec8 
…ository' into feature/add_jacoco_support
@miroslavpojer
* Merged source branch.
f897094 
* Updated README.md to provide hint how to run JaCoCo code coverage tooling.
@miroslavpojer
Copy link
Collaborator Author

It would be good to document some usages / supported types etc into README, but otherwise really good work, I like the Either approach you chose, apart from many other things :)

Documented in README.md in commit f897094,

@benedeki benedeki removed the dependent The item depends on some other open item (Issue or PR) label Dec 8, 2023
lsulak
lsulak reviewed Dec 11, 2023
View reviewed changes
project/plugins.sbt Outdated
def armUrl(scalaMajor: String): String = s"https://repo1.maven.org/maven2/com/jsuereth/scala-arm_$scalaMajor/$scalaArmVersion/scala-arm_$scalaMajor-$scalaArmVersion.jar"

addSbtPlugin("com.jsuereth" %% "scala-arm" % scalaArmVersion from armUrl("2.11"))
addSbtPlugin("com.jsuereth" %% "scala-arm" % scalaArmVersion from armUrl("2.12"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those scala-arm - are they actually used?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that they are indirectly - they are needed for jacoco itself.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, They are needed for current solution. I guess it could be done better, but I still hope I will be able to refactor all this solution.

lsulak
lsulak reviewed Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@lsulak lsulak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I noticed that the GH Pipeline definition for adding code coverage into PRs is missing.

LGTM otherwise

@miroslavpojer
Copy link
Collaborator Author

miroslavpojer commented Dec 11, 2023 •
edited
Loading

Actually I noticed that the GH Pipeline definition for adding code coverage into PRs is missing.

LGTM otherwise

You are right, I will add it.
@lsulak, @benedeki What do you prefer?

  • remove 2.12 from build.yml and call it in a separated jacoco.yml file?
  • call tests for 2.12 twice but in the second round with JaCoCo support?

I would follow the second option as depends on the job on build.yml. I have prepared it already.

@github-actions GitHub Actions
Copy link

JaCoCo code coverage report - balta

File Coverage [0%] ❌
SetterFnc.scala 0% ❌
Total Project Coverage 0% 🍏

@benedeki benedeki changed the title Feature/add jacoco support #11: Introduce code coverage measuring by JaCoCo Sep 28, 2024
@benedeki
Merge remote-tracking branch 'remotes/origin/master' into feature/add…
e0c8046 
…_jacoco_support

# Conflicts:
#	README.md
#	balta/src/main/scala/za/co/absa/db/balta/classes/setter/SetterFnc.scala
#	build.sbt
@github-actions GitHub Actions
Copy link

JaCoCo 'balta' module code coverage report - scala 2.12.18

Overall Project 30.04% 🍏

There is no coverage information present for the Files changed

@benedeki benedeki merged commit 7298aaf into master Sep 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsulak lsulak lsulak left review comments

@benedeki benedeki Awaiting requested review from benedeki benedeki is a code owner

@salamonpavel salamonpavel Awaiting requested review from salamonpavel salamonpavel is a code owner

Assignees

@miroslavpojer miroslavpojer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce code coverage measuring by JaCoCo
3 participants
@miroslavpojer @lsulak @benedeki