Run tests after building wheels #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes cibuildwheel test the wheels themselves by installing them and running the tests in an isolated env after the build.
Additionally, I figured there is probably no point in duplicating the same work and I removed the
install_and_testjob that the wheel build depended on. While doing so, I noticed that theneedsforupload_pypijob doesn't actually depend on the sdist job to finish, even though it requires its output so I fixed that at the same time.I think that adding the
test-commanditself is probably non-controversial but I'm not as sure aboutinstall_and_test. Let me know, if you think that I should keep it.Since I also made #14 at the same time, I ran a workflow job with both of these merged here:
https://github.com/Jackenmen/audioop/actions/runs/10220145547?pr=3
The ideal scenario would be to have both of these merged to ensure that the cross-compiled wheels pass the tests. I should note that the Windows ARM64 build can only be tested on an arm64 runner and therefore that could not be tested.