Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-compile wheels for Windows ARM64 and Linux aarch64/ppc64le/s390x #14

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

Jackenmen
Copy link
Contributor

This PR adds wheels for more platforms! Notably, Windows ARM64 and Linux aarch64 are now built. Since the package can be built on ppc64le and s390x platforms as well, I enabled that too.

To make sure that the total time of the build doesn't skyrocket, I split out the native and emulated builds in the job matrix (c12729b). This makes it so that the build takes ~4 minutes rather ~13-14 minutes.


Since I also made #13 at the same time, I ran a workflow job with both of these merged here:
https://github.com/Jackenmen/audioop/actions/runs/10220145547?pr=3
The ideal scenario would be to have both of these merged to ensure that the cross-compiled wheels pass the tests. I should note that the Windows ARM64 build can only be tested on an arm64 runner and therefore that could not be tested.

Copy link
Owner

@AbstractUmbra AbstractUmbra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@AbstractUmbra AbstractUmbra merged commit 6d232c5 into AbstractUmbra:main Aug 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants