Update related input attribute when renaming a nodegraph #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjtxietian
commented
Jul 10, 2024
jsjtxietian
commented
Jul 10, 2024
|
This looks very promising, thanks @jsjtxietian! I'm CC'ing @lfl-eholthouser, who knows this code the best, for her thoughts and suggestions. |
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
jstone-lucasfilm
changed the title
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
jstone-lucasfilm
approved these changes
Jul 13, 2024
jstone-lucasfilm
changed the title
jstone-lucasfilm
merged commit a86f677
into
AcademySoftwareFoundation:main
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1912
The problem is that after renaming, the input PortElement's
_attributeMapstill hold the old name, so when drawing the graph,getConnectedOutputfailed.