Fix missing import in powershell plugin #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Thorsten, would you mind dropping some TODO comments in so that the existing problems are identified? Cheers! |
|
Not at all, will go ahead asap. The powershell 6+ stuff is more a new ticket rather than comments as it will be a separate file. I also forgot another thing: I can possibly replace the existing registry hacks to get the clean system env with something more elegant in powershell. But i have to research fist. Will add TODO notes and report here. |
|
Realized i had another mishap. Fixed and added TODOs for the two things i have in mind. Will create an issue for pwsh support. The fix has been tested with a few powershell ready packages i have that make proper use of the tweaked alias() setup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A missing import slipped into the last MR. I do think that the powershell plugin needs some more work. Most notably i would like it to properly escape paths on alias() calls. But that is way less trivial than it sounds at first. I also plan adding a second plugin for poweshell6+. It will be separate because it actually has differing feature sets and it also has a different executable name (pwsh).
The only functional change is the added import on top. The rest is auto-formatting for pep8 in vscode.