Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing import subprocess #683

Closed
wants to merge 1 commit into from
Closed

Add missing import subprocess #683

wants to merge 1 commit into from

Conversation

dsagilles
Copy link

resolving a powershell environment in windows would otherwise give me "NameError: global name 'subprocess' is not defined" (powershell.py line 108)

resolving a powershell environment in windows would otherwise give me "NameError: global name 'subprocess' is not defined" (powershell.py line 108)
@nerdvegas
Copy link
Contributor

Thanks. Seems related to #674. Will get this merged next week.

@instinct-vfx
Copy link
Contributor

Both PRs fix the same issue, mine also has the ToDo comment for updating the way PATH is fetched from the registry. If this PR is preferred (because it does not include autoformatting updates, not sure what your stance on these is) then please also include the ToDo note in line 85/86.

@nerdvegas
Copy link
Contributor

Closing in favor of #674.

RE autoformatting - I prefer not to have that mixed in with functional PRs. However at some point I would very much like to blacken the source (https://github.com/psf/black), at which point any discussion on formatting is moot (and there'd be a pre-commit hook to enforce).

@nerdvegas nerdvegas closed this Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants