Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pytorch Tutorial 3 - Mixed and Half precision - Jupter Notebook and Markdown #85

Merged
merged 5 commits into from
Oct 12, 2021
Merged

Pytorch Tutorial 3 - Mixed and Half precision - Jupter Notebook and Markdown #85

merged 5 commits into from
Oct 12, 2021

Conversation

Adamage
Copy link
Owner

@Adamage Adamage commented Oct 4, 2021

Various comments and markdown added to the source script, inspired by the "old" readme.md file.

Closing #64

@Adamage Adamage requested review from LRVerkin and plutasnyy October 4, 2021 12:48
@Adamage Adamage self-assigned this Oct 4, 2021
@Adamage Adamage changed the title Issue #64 - Pytorch Tutorial 3 - Jupter Notebook and Markdown Pytorch Tutorial 3 - Jupter Notebook and Markdown Oct 4, 2021
@Adamage Adamage changed the title Pytorch Tutorial 3 - Jupter Notebook and Markdown Pytorch Tutorial 3 - Mixed and Half precision - Jupter Notebook and Markdown Oct 5, 2021
@plutasnyy plutasnyy linked an issue Oct 6, 2021 that may be closed by this pull request
Tutorial 3 - PyTorch Tutorial 3 Mixed Precision #64
Closed
dirkbrink
dirkbrink suggested changes Oct 8, 2021
View reviewed changes
tutorials/pytorch/tut3_mixed_precision/README.md Outdated Show resolved Hide resolved
tutorials/pytorch/tut3_mixed_precision/README.md Outdated Show resolved Hide resolved
tutorials/pytorch/tut3_mixed_precision/README.md Show resolved Hide resolved
tutorials/pytorch/tut3_mixed_precision/README.md Outdated Show resolved Hide resolved
tutorials/pytorch/tut3_mixed_precision/README.md Show resolved Hide resolved
tutorials/pytorch/tut3_mixed_precision/README.md Outdated Show resolved Hide resolved
tutorials/pytorch/tut3_mixed_precision/README.md Show resolved Hide resolved
tutorials/pytorch/tut3_mixed_precision/README.md Show resolved Hide resolved
tutorials/pytorch/tut3_mixed_precision/README.md Show resolved Hide resolved
tutorials/pytorch/tut3_mixed_precision/README.md Outdated Show resolved Hide resolved
@Adamage
Copy link
Owner Author

Adamage commented Oct 11, 2021

@dirkbrink applied all the discussed changes, we have 2 more open ones, please take a look at my replies, thanks!

dirkbrink
dirkbrink suggested changes Oct 12, 2021
View reviewed changes
Copy link

@dirkbrink dirkbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

poptorch.poptorch_core.Error: 'poptorch_py_error': AsynchronousDataAccessor worker thread failed to start (Check above for details)

This error occurs when trying to run the source and code_only files

@Adamage
Copy link
Owner Author

Adamage commented Oct 12, 2021

@dirkbrink I see, this happened because yesterday I changed the DataLoader mode to Async. In that case, the source script must be guarded by __main__. In this tutorial this was not the highlighted functionality, I will revert this mode change.

It is highlighted in other tutorials

@Adamage
Copy link
Owner Author

Adamage commented Oct 12, 2021

The warning printed about MNIST tensor being non-writable was handled in this PR
pytorch/vision#4184

dirkbrink
dirkbrink approved these changes Oct 12, 2021
View reviewed changes
Copy link

@dirkbrink dirkbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once you've made the small change, feel free to squash and merge 👍

tutorials/pytorch/tut3_mixed_precision/README.md Outdated Show resolved Hide resolved
@Adamage Adamage merged commit 090e9a6 into main Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkbrink dirkbrink dirkbrink approved these changes

@plutasnyy plutasnyy plutasnyy approved these changes

@LRVerkin LRVerkin Awaiting requested review from LRVerkin

Assignees

@Adamage Adamage

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tutorial 3 - PyTorch Tutorial 3 Mixed Precision
3 participants
@Adamage @plutasnyy @dirkbrink