Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed MNIST Download Raises 'UserWarning: The given NumPy array is not writeable' #4184

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Fixed MNIST Download Raises 'UserWarning: The given NumPy array is not writeable' #4184

merged 1 commit into from
Jul 15, 2021

Conversation

JAEarly
Copy link
Contributor

@JAEarly JAEarly commented Jul 15, 2021

Fix as discussed in #4183

@JAEarly
Removed copy=False from torch.from_numpy
da0d5c3 
Stops a UserWarning from being raised as the NumPy array is not writeable.
@facebook-github-bot
Copy link

Hi @JAEarly!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

NicolasHug
NicolasHug approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JAEarly

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@NicolasHug NicolasHug merged commit c332a7f into pytorch:master Jul 15, 2021
@pmeier pmeier mentioned this pull request Jul 16, 2021
Closed
@ain-soph ain-soph mentioned this pull request Jul 22, 2021
Closed
facebook-github-bot pushed a commit that referenced this pull request Jul 27, 2021
@NicolasHug @facebook-github-bot
[fbsync] Removed copy=False in torch.from_numpy in MNIST to avoid war…
c3825b4 
…ning (#4184)

Reviewed By: fmassa

Differential Revision: D29932695

fbshipit-source-id: d910f6611d377548b2c3cd6cd09707b9eeae074b
@NicolasHug NicolasHug mentioned this pull request Aug 20, 2021
Closed
@Adamage Adamage mentioned this pull request Oct 12, 2021
Merged
@pmeier pmeier mentioned this pull request Oct 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

Assignees
No one assigned
Labels
cla signed code quality module: datasets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JAEarly @facebook-github-bot @NicolasHug