Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Use Github Actions for tests #842

Merged
merged 16 commits into from
Nov 17, 2020

Conversation

bantic
Copy link
Contributor

@bantic bantic commented Nov 2, 2020

Note This is based on the 3.0-beta branch, not master.

Run tests at github actions. The open-source queue for the Travis tests is variable and sometimes the tests at travis are stuck in the queue for hours. Github Actions run much more quickly (and predictably).

Changes:

@bantic bantic force-pushed the bantic-jiaying/use-github-actions branch 3 times, most recently from 53c5890 to c69370e Compare November 6, 2020 21:31
@bantic bantic force-pushed the bantic-jiaying/use-github-actions branch from 99e43b8 to 2a9f4a4 Compare November 17, 2020 19:13
@bantic bantic changed the base branch from master to 3.0-beta November 17, 2020 19:13
@bantic bantic marked this pull request as ready for review November 17, 2020 20:33
@bantic bantic requested a review from jiayingxu November 17, 2020 20:33
Copy link
Contributor

@jiayingxu jiayingxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks great! Switching to Github Actions will hugely improve developer productivity in ember-table.

@bantic bantic merged commit 72a2b78 into 3.0-beta Nov 17, 2020
@bantic bantic deleted the bantic-jiaying/use-github-actions branch November 17, 2020 21:27
@VelDeveloper
Copy link

@bantic Could you please elaborate this point a bit

Add a resolution on ember-compatibility-helpers@1.2.1 in the ember-try scenarios for 2.4 and 2.8 to work around a bug in 1.2.2 when the ember-source package is not present, see pzuraq/ember-compatibility-helpers#47

I am still struggling with this issue ....It would be really helpful if you elaborate a bit. I never used ember try. How it resolve my problem?

@bantic
Copy link
Contributor Author

bantic commented Nov 19, 2020

@VelDeveloper Sure thing — the resolution on ember-compatibility-helpers@1.2.1 ensures that the yarn install that ember-try runs will install that version of ember-compatibility-helpers even if some other of your dependencies themselves have a dependency on a new version of ember-compatibility-helpers.

You can read more about resolutions here: https://classic.yarnpkg.com/en/docs/selective-version-resolutions/

ember-try is a tool for testing ember addons against different versions of ember and probably not directly relevant to your issue: https://github.com/ember-cli/ember-try

I added some more details on the upstream issue, too: ember-cli/ember-compatibility-helpers#47 (comment)

NullVoxPopuli pushed a commit to NullVoxPopuli/ember-table that referenced this pull request Feb 2, 2021
johanrd pushed a commit to johanrd/ember-table that referenced this pull request Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants