-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] Use Github Actions for tests #842
Conversation
53c5890
to
c69370e
Compare
99e43b8
to
2a9f4a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Looks great! Switching to Github Actions will hugely improve developer productivity in ember-table
.
@bantic Could you please elaborate this point a bit
I am still struggling with this issue ....It would be really helpful if you elaborate a bit. I never used |
@VelDeveloper Sure thing — the resolution on ember-compatibility-helpers@1.2.1 ensures that the You can read more about resolutions here: https://classic.yarnpkg.com/en/docs/selective-version-resolutions/ ember-try is a tool for testing ember addons against different versions of ember and probably not directly relevant to your issue: https://github.com/ember-cli/ember-try I added some more details on the upstream issue, too: ember-cli/ember-compatibility-helpers#47 (comment) |
Note This is based on the
3.0-beta
branch, notmaster
.Run tests at github actions. The open-source queue for the Travis tests is variable and sometimes the tests at travis are stuck in the queue for hours. Github Actions run much more quickly (and predictably).
Changes:
ember-source
package is not present, see Latest version failed with errorCannot read property 'match' of undefined
ember-cli/ember-compatibility-helpers#47