Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] [tests] Only run "ember test" in primary workflow job #844

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

bantic
Copy link
Contributor

@bantic bantic commented Nov 17, 2020

Note: Targets base of 3.0-beta not master

PR #842 accidentally runs all ember tests via ember try:each in the primary workflow job. This
fixes that to only run the current dependencies. The matricized job runs the ember-try scenarios.

Copy link
Contributor

@jiayingxu jiayingxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bantic bantic merged commit 209f12f into 3.0-beta Nov 17, 2020
@bantic bantic deleted the bantic/fix-github-actions-tests branch November 17, 2020 22:05
NullVoxPopuli pushed a commit to NullVoxPopuli/ember-table that referenced this pull request Feb 2, 2021
johanrd pushed a commit to johanrd/ember-table that referenced this pull request Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants