Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name of custom filter don't save after adding the same one with new name #239

Closed
SoLenny opened this issue Sep 10, 2019 · 2 comments
Closed

Name of custom filter don't save after adding the same one with new name #239

SoLenny opened this issue Sep 10, 2019 · 2 comments
Assignees
@kaprielov @Mizzick

Comments

@SoLenny
Copy link

SoLenny commented Sep 10, 2019

We need to decide what should do AdGuard when user adding custom filter which is already installed.
Error or maybe something else?
@SoLenny SoLenny added Bug Something isn't working P4: Low Low priority UI labels Sep 10, 2019
@SoLenny SoLenny added this to the 1.6 milestone Sep 10, 2019
@Mizzick
Copy link
Contributor

Mizzick commented Oct 9, 2019

I agree, it would be better to update existing instance with new properties such as name, trusted flag etc.

@Mizzick
Copy link
Contributor

Mizzick commented Oct 18, 2019

Works as expected.
Adding custom filter with the same url (url is an identifier for these filters) results in updating filter properties: name and trusted

@Mizzick Mizzick added the Cannot reproduce We cannot reproduce this issue label Oct 18, 2019
@SoLenny SoLenny removed Bug Something isn't working Cannot reproduce We cannot reproduce this issue P4: Low Low priority UI labels Oct 25, 2019
@SoLenny SoLenny removed this from the 1.6 milestone Oct 25, 2019
@SoLenny SoLenny closed this as completed Oct 25, 2019
Mizzick added a commit that referenced this issue Nov 28, 2019
@Mizzick
Merge pull request #239 in EXTENSIONS/safari-app-extension from misc-…
8620f9a 
…fix to master

* commit '373cda424b395b5ea6fc08d5c5b980844baa6ea4':
  #299 hardware acceleration
  #299 hardware acceleration
  #299 hardware acceleration
  advanced blocking extension logging
  add cb extensions logging
  add cb extensions logging
  fix about page layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaprielov kaprielov

@Mizzick Mizzick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kaprielov @Mizzick @SoLenny