Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardware acceleration #299

Closed
ameshkov opened this issue Nov 21, 2019 · 3 comments
Closed

Hardware acceleration #299

ameshkov opened this issue Nov 21, 2019 · 3 comments
Assignees
@Mizzick
Labels
Enhancement A new feature that we are planning to implement P3: Medium Medium priority
Milestone
1.6

Comments

@ameshkov
Copy link
Member

  1. Make it enabled by default
  2. Add "Disable hardware acceleration" option to general settings
@ameshkov ameshkov added the Enhancement A new feature that we are planning to implement label Nov 21, 2019
@ameshkov ameshkov added this to the 1.6 milestone Nov 21, 2019
@Mizzick
Copy link
Contributor

Mizzick commented Nov 21, 2019

It has been disabled cause of #110, #165
I have just tested it and there is no issues with current build.

So do you really want to make such a low-level option in general settings?

@ameshkov
Copy link
Member Author

@Mizzick well, that's what Slack does, and I think it makes sense.

@ameshkov ameshkov added the P3: Medium Medium priority label Nov 25, 2019
Mizzick added a commit that referenced this issue Nov 28, 2019
@Mizzick
#299 hardware acceleration
9d00d1b
Mizzick added a commit that referenced this issue Nov 28, 2019
@Mizzick
#299 hardware acceleration
beaf642
Mizzick added a commit that referenced this issue Nov 28, 2019
@Mizzick
#299 hardware acceleration
373cda4
Mizzick added a commit that referenced this issue Nov 28, 2019
@Mizzick
Merge pull request #239 in EXTENSIONS/safari-app-extension from misc-…
8620f9a 
…fix to master

* commit '373cda424b395b5ea6fc08d5c5b980844baa6ea4':
  #299 hardware acceleration
  #299 hardware acceleration
  #299 hardware acceleration
  advanced blocking extension logging
  add cb extensions logging
  add cb extensions logging
  fix about page layout
@s4y
Copy link

s4y commented Dec 24, 2019

Drive-by comment: It looks like that issue affects specific older Mac laptops because of problems with the integrated GPU. Chrome opted to force the discrete GPU on those machines instead of turning off acceleration completely. In an ideal world, Electron could automatically turn off hardware acceleration just on those machines and leave it on for other machines. As-is, a setting feels like overkill.

@zzebrum zzebrum closed this as completed Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mizzick Mizzick

Labels
Enhancement A new feature that we are planning to implement P3: Medium Medium priority
Projects
None yet
Milestone
1.6
Development

No branches or pull requests
4 participants
@s4y @ameshkov @Mizzick @zzebrum