Merge pull request #1885 from Agenta-AI/AGE-399/-Test-creation-in-sin…

…gle-model-eval-does-not-work-in-table-view fix(frontend): Test creation in single model eval does not work in table view
Agenta-AI · Jul 15, 2024 · 00d96ee · 00d96ee
2 parents a8cacec + 1bbbe7f
commit 00d96ee
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/agenta-web/src/components/EvaluationTable/SingleModelEvaluationTable.tsx b/agenta-web/src/components/EvaluationTable/SingleModelEvaluationTable.tsx
@@ -193,7 +193,7 @@ const SingleModelEvaluationTable: React.FC<EvaluationTableProps> = ({
         debounce((data: Partial<EvaluationScenario>, scenarioId) => {
             updateEvaluationScenarioData(scenarioId, data)
         }, 800),
-        [evaluationScenarios],
+        [rows],
     )
 
     useEffect(() => {
@@ -278,7 +278,7 @@ const SingleModelEvaluationTable: React.FC<EvaluationTableProps> = ({
             .then(() => {
                 Object.keys(data).forEach((key) => {
                     setRowValue(
-                        evaluationScenarios.findIndex((item) => item.id === id),
+                        rows.findIndex((item) => item.id === id),
                         key,
                         data[key as keyof EvaluationScenario],
                     )

diff --git a/agenta-web/src/components/Evaluations/EvaluationCardView/index.tsx b/agenta-web/src/components/Evaluations/EvaluationCardView/index.tsx
@@ -4,8 +4,6 @@ import {
     LeftOutlined,
     LoadingOutlined,
     PlayCircleOutlined,
-    PushpinFilled,
-    PushpinOutlined,
     QuestionCircleOutlined,
     RightOutlined,
 } from "@ant-design/icons"
@@ -18,7 +16,6 @@ import {ABTestingEvaluationTableRow} from "@/components/EvaluationTable/ABTestin
 import AlertPopup from "@/components/AlertPopup/AlertPopup"
 import {useLocalStorage} from "usehooks-ts"
 import {testsetRowToChatMessages} from "@/lib/helpers/testset"
-import {safeParse} from "@/lib/helpers/utils"
 import {debounce} from "lodash"
 import {EvaluationType} from "@/lib/enums"
 import ParamsForm from "@/components/Playground/ParamsForm/ParamsForm"