Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): Test creation in single model eval does not work in table view #1885

Merged
merged 2 commits into from
Jul 15, 2024
Merged

fix(frontend): Test creation in single model eval does not work in table view #1885

merged 2 commits into from
Jul 15, 2024

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented Jul 13, 2024 •
edited
Loading

Description

This Pull Request addresses an issue in the Single Model Test Evaluation where modifications made to the Expected Output column are not saved when creating a new test set.

Related Issue

Closes AGE-399

Steps to Reproduce the Issue:

  1. Create a single model evaluation.
  2. Move to table view.
  3. Create an annotation (modify the correct answer).
  4. Click on Save test set.
  5. You will find that the newly created test set does not include the modifications you made.

Jam Recording

@vercel Vercel
Copy link

vercel bot commented Jul 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2024 11:08pm

@bekossy bekossy changed the title [Bug]: Test creation in single model eval does not work in table view fix(frontend): Test creation in single model eval does not work in table view Jul 15, 2024
@bekossy bekossy marked this pull request as ready for review July 15, 2024 09:05
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 15, 2024
@bekossy bekossy requested a review from aakrem July 15, 2024 09:05
@dosubot dosubot bot added bug Something isn't working Frontend labels Jul 15, 2024
aakrem
aakrem approved these changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@aakrem aakrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bekossy 👍 👍 👍

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 15, 2024
@aakrem aakrem merged commit 00d96ee into main Jul 15, 2024
8 checks passed
@aakrem aakrem deleted the AGE-399/-Test-creation-in-single-model-eval-does-not-work-in-table-view branch July 15, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aakrem aakrem aakrem approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Frontend lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bekossy @aakrem