Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Fix]: Improved conditional logic for creating evaluator #1729

Merged
merged 4 commits into from
Jun 2, 2024
Merged

[Bug Fix]: Improved conditional logic for creating evaluator #1729

merged 4 commits into from
Jun 2, 2024

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented Jun 1, 2024

No description provided.

@bekossy bekossy requested a review from mmabrouk June 1, 2024 10:55
@vercel Vercel
Copy link

vercel bot commented Jun 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 10:34am

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working Frontend labels Jun 1, 2024
mmabrouk
mmabrouk approved these changes Jun 1, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bekossy for the quick fix. But can we add some error handling too, so that even if we get errors later, it does not infinetly load but show instead some message.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 1, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jun 1, 2024
@bekossy
Copy link
Member Author

bekossy commented Jun 1, 2024

Thanks for the feedback @mmabrouk, I have made the requested changes

mmabrouk
mmabrouk requested changes Jun 2, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

agenta-web/src/components/pages/evaluations/evaluators/NewEvaluatorModal.tsx Show resolved Hide resolved
@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Jun 2, 2024
@bekossy bekossy requested a review from mmabrouk June 2, 2024 10:19
mmabrouk
mmabrouk approved these changes Jun 2, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @bekossy ! Very neat solution

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 2, 2024
@mmabrouk mmabrouk merged commit d6372fa into main Jun 2, 2024
8 checks passed
@mmabrouk mmabrouk deleted the hot-fix/-improved-conditional-logic-for-creating-evaluator branch June 2, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmabrouk mmabrouk mmabrouk approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Frontend lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bekossy @mmabrouk