Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix]: Improved conditional logic for creating evaluator #1729

Merged
merged 4 commits into from
Jun 2, 2024
Merged

[Bug Fix]: Improved conditional logic for creating evaluator #1729

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ecc91c
improved conditional logic for creating evaluator
bekossy Jun 1, 2024
dc64985
improved error handling
bekossy Jun 1, 2024
4ae8208
Refactor settingsValues init to use default values
bekossy Jun 2, 2024
c42f31c
revert changes and forced Collapse component to render when closed
bekossy Jun 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions agenta-web/src/components/pages/evaluations/evaluators/NewEvaluatorModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,8 +266,6 @@ const NewEvaluatorModal: React.FC<Props> = ({

const advancedSettingsFields = evalFields.filter((field) => field.advanced)
const basicSettingsFields = evalFields.filter((field) => !field.advanced)
console.log(evalFields)
console.log(basicSettingsFields)

const onSubmit = (values: CreateEvaluationConfigData) => {
setSubmitLoading(true)
Expand All @@ -276,7 +274,7 @@ const NewEvaluatorModal: React.FC<Props> = ({

if (
!settingsValues.correct_answer_key &&
bekossy marked this conversation as resolved.
Show resolved Hide resolved
selectedEval.settings_template.correct_answer_key.default
selectedEval.settings_template.correct_answer_key?.default
) {
settingsValues["correct_answer_key"] =
selectedEval.settings_template.correct_answer_key.default
Expand Down
Loading