Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve merge conflict between postgres and main #1854

Merged
merged 47 commits into from
Jul 7, 2024

Conversation

aybruhm
Copy link
Member

@aybruhm aybruhm commented Jul 7, 2024

Description

This PR resolves the merge conflict between the postgres branch and main due to changes in the evaluation service logic. The conflicts arose because of modifications made in the main branch involving evaluation service. This update ensures that all changes are correctly in sync and the service functions as expected.

See last four commits for the resolved conflicts.

bekossy and others added 30 commits May 26, 2024 13:09
Handle uncaught exceptions in aggregate_ai_critique() and in evaluate()
Evaluations are initially Queued and only move to Started when the worker actually starts on the task.
Improve stacktrace quality in evaluations. Still not shown in UI.
Catch None-related issue in Optional[...] field: EvaluationResult.correct_answers
Adds logger.error(e) for exception in evaluation router
…ng-in-evaluation

Improve error handling in evaluation
Func errors used to be set as func result. Now they are propagated up by forwarding the exception up (raise e).
Remove redundant celery state updates, update celery configuration, use enum properly.
Standardizes stacktrace to traceback.format_exc() (in all three files)  and message to str(exc) (in aggregation_service.py)
Fix issue where Evaluation Results don't load when individual Evaluation Scenarios fail
Copy link

vercel bot commented Jul 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2024 0:12am

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jul 7, 2024
@aybruhm aybruhm changed the title Main to postgres merge Resolve merge conflict between postgres and main Jul 7, 2024
Copy link
Collaborator

@aakrem aakrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @aybruhm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 7, 2024
@aakrem aakrem merged commit a12a206 into postgres Jul 7, 2024
10 checks passed
@aakrem aakrem deleted the main-to-postgres-merge branch July 7, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend CLI Frontend lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants