Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: small UI issues in overview page #2027

Merged
merged 9 commits into from
Sep 9, 2024
Merged

Fix: small UI issues in overview page #2027

merged 9 commits into from
Sep 9, 2024

Conversation

ashrafchowdury
Copy link
Collaborator

Description

Fixed the small UI issues in the overview page.

Fixes

  • A/B testing datapoints incorrect font size.
  • Padding and gap issue on deployment card.
  • Truncate long app names in side menu.
  • Automatic results popover should be visible on hover.

@vercel Vercel
Copy link

vercel bot commented Aug 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 1:26pm
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 1:26pm

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 27, 2024
@ashrafchowdury ashrafchowdury requested a review from bekossy August 27, 2024 05:01
@dosubot dosubot bot added bug Something isn't working UI labels Aug 27, 2024
bekossy
bekossy requested changes Aug 27, 2024
View reviewed changes
Copy link
Member

@bekossy bekossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @ashrafchowdury. Let's replace hardcoded values with Ant Design's theme variables

@ashrafchowdury ashrafchowdury requested a review from bekossy August 27, 2024 12:25
@ashrafchowdury ashrafchowdury requested a review from bekossy August 27, 2024 12:51
@ashrafchowdury ashrafchowdury requested a review from bekossy August 27, 2024 13:23
bekossy
bekossy approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@bekossy bekossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @ashrafchowdury

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 27, 2024
@aakrem aakrem merged commit 6f1c87b into main Sep 9, 2024
9 checks passed
@aakrem aakrem deleted the fix/small-ui-issues branch September 9, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bekossy bekossy bekossy approved these changes

@aakrem aakrem Awaiting requested review from aakrem

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files. UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashrafchowdury @aakrem @bekossy