Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: small UI issues in overview page #2027

Merged
merged 9 commits into from
Sep 9, 2024
Merged

Fix: small UI issues in overview page #2027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
22212b9
fix: long app names in side menu
ashrafchowdury Aug 26, 2024
b894edc
fix: A/B testing datapoints font size in app overview
ashrafchowdury Aug 26, 2024
39465f4
fix: padding and gap issue on deployment card
ashrafchowdury Aug 26, 2024
fb56531
fix: automatic results popover visible on hover
ashrafchowdury Aug 26, 2024
ff85a75
fix: button icon alignment issue in sidebar
ashrafchowdury Aug 27, 2024
43e7f4f
Merge branch 'main' of https://github.com/Agenta-AI/agenta into fix/s…
ashrafchowdury Aug 27, 2024
e40d853
refactor: removed hard coded values
ashrafchowdury Aug 27, 2024
fd6220e
refactor: removed hard coded inline height
ashrafchowdury Aug 27, 2024
dafef16
fix: large padding issue
ashrafchowdury Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions agenta-web/src/components/Sidebar/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ const useStyles = createUseStyles((theme: JSSTheme) => ({
},
menuItem: {
textOverflow: "initial !important",
display: "flex !important",
alignItems: "center",
},
avatarContainer: {
display: "flex",
Expand All @@ -113,6 +115,9 @@ const useStyles = createUseStyles((theme: JSSTheme) => ({
menuHeader: {
padding: `${theme.paddingXS}px ${theme.padding}px`,
color: theme.colorTextDescription,
overflow: "hidden",
textOverflow: "ellipsis",
whiteSpace: "nowrap",
},
}))

Expand Down
15 changes: 9 additions & 6 deletions agenta-web/src/components/pages/overview/abTestingEvaluation/AbTestingEvalOverview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,32 +33,35 @@ const useStyles = createUseStyles((theme: JSSTheme) => ({
},
},
statFlag: {
lineHeight: theme.lineHeight,
"& .ant-statistic-content-value": {
fontSize: 16,
fontSize: theme.fontSize,
color: theme.colorError,
},
"& .ant-statistic-content-suffix": {
fontSize: 16,
fontSize: theme.fontSize,
color: theme.colorError,
},
},
stat: {
lineHeight: theme.lineHeight,
"& .ant-statistic-content-value": {
fontSize: 16,
fontSize: theme.fontSize,
color: theme.colorPrimary,
},
"& .ant-statistic-content-suffix": {
fontSize: 16,
fontSize: theme.fontSize,
color: theme.colorPrimary,
},
},
statGood: {
lineHeight: theme.lineHeight,
"& .ant-statistic-content-value": {
fontSize: 16,
fontSize: theme.fontSize,
color: theme.colorSuccess,
},
"& .ant-statistic-content-suffix": {
fontSize: 16,
fontSize: theme.fontSize,
color: theme.colorSuccess,
},
},
Expand Down
4 changes: 2 additions & 2 deletions agenta-web/src/components/pages/overview/automaticEvaluation/AutomaticEvalOverview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ const AutomaticEvalOverview = () => {
<Popover
key={index}
placement="bottom"
trigger={"click"}
trigger={"hover"}
aakrem marked this conversation as resolved.
Show resolved Hide resolved
arrow={false}
content={
<div className="w-[256px]">
Expand All @@ -274,7 +274,7 @@ const AutomaticEvalOverview = () => {
<Popover
key={index}
placement="bottom"
trigger={"click"}
trigger={"hover"}
arrow={false}
content={
<div
Expand Down
7 changes: 5 additions & 2 deletions agenta-web/src/components/pages/overview/deployments/DeploymentOverview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const useStyles = createUseStyles((theme: JSSTheme) => ({
},
cardContainer: {
display: "flex",
gap: theme.paddingXS,
gap: theme.padding,
"& .ant-card": {
width: "100%",
position: "relative",
Expand Down Expand Up @@ -156,7 +156,10 @@ const DeploymentOverview = ({
env={env}
/>
) : (
<Tag className="w-fit" onClick={(e) => e.stopPropagation()}>
<Tag
className="w-fit py-[1px] px-2"
onClick={(e) => e.stopPropagation()}
>
No deployment
</Tag>
)}
Expand Down
5 changes: 3 additions & 2 deletions agenta-web/src/components/pages/overview/singleModelEvaluation/SingleModelEvalOverview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,13 @@ const useStyles = createUseStyles((theme: JSSTheme) => ({
},
},
stat: {
lineHeight: theme.lineHeight,
"& .ant-statistic-content-value": {
fontSize: 16,
fontSize: theme.fontSize,
color: theme.colorPrimary,
},
"& .ant-statistic-content-suffix": {
fontSize: 16,
fontSize: theme.fontSize,
color: theme.colorPrimary,
},
},
Expand Down
5 changes: 4 additions & 1 deletion agenta-web/src/components/pages/overview/variants/VariantPopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,10 @@ const VariantPopover = ({env, selectedDeployedVariant, ...props}: VariantPopover
</div>
}
>
<Tag className="w-fit cursor-pointer" onClick={(e) => e.stopPropagation()}>
<Tag
className="w-fit cursor-pointer py-[1px] px-2"
onClick={(e) => e.stopPropagation()}
>
<Badge
color={token.colorPrimary}
text={formatVariantIdWithHash(env.deployed_app_variant_id as string)}
Expand Down