Team Meetings Agendas and Notes for 2018
Note items for discussion and put them in the "parking lot". That way we won't forget about it and we'll be sure to go over it in the meeting. Put your name in there so we know whose idea it is.
- End of year membership renewals are coming up:
- Send out emails: Still waiting for membership payment; Still waiting for H-Branding fee payment
- additional emails: membership about to expire, has lapsed, need more info, etc.
- [Pat] Wah!!! I need my debugger back!
- [Pat] Chromedriver version
- This is now breaking tests locally - do we still need it?:
Chromedriver.set_version "2.24" unless ENV.has_key?('SEMAPHORECI')
- [Ashley] h-branding due calculation - what is zero day?
Note items for discussion and put them in the "parking lot". That way we won't forget about it and we'll be sure to go over it in the meeting. Put your name in there so we know whose idea it is.
- End of year membership renewals are coming up:
- Send out emails: Still waiting for membership payment; Still waiting for H-Branding fee payment
- additional emails: membership about to expire, has lapsed, need more info, etc.
[Susanna] Next e-mail to send out should be pay H-branding Because not everyone remembers that while paying their membership fee.
-
Will we have the same issue as membership fee ‘overdue’: do we need to know what the ‘start date’ is for the H-Branding fee so that we can determine how many days ‘overdue’ it is?
Or…
for now, should we just define a simple ‘alert’ that runs every X nights (perhaps weekly) and if a h-branding fee is owed, send out an email?
[Ashley] Date to start counting a member as "overdue" for paying membership fee
- for legacy members?
- or am I misinterpreting?
- is this the same as PT: Email alert to: Member's application = Accepted but have not paid their membership fee
[Ashley] Since we're sending out so many email now (or will be very soon), is getting info from Mailgun a higher priority? E.g. showing bounced, sent, etc. on the admin dashboard
[Susanna] Possible feature: When an application is deleted, allow that membership number to be reused
- this implies that an admin can manually assign a membership number
Mark as "Accept" (feature), "Deliver" (bug), or "Finished" (chore) if team agrees
- new Bug: Users/members cannot change contact e-mail
-
What needs to be specifically reviewed and refactored?
-
Status of current refactoring work
[Ashley] After the New Year, I'd like to discuss the pros and cons of using Github for issue tracking. Pro: would make the project much more public, and so would open up the possibility of having more help. Con: We'd have to figure out a new tool (one that integrates with Github).
Note items for discussion and put them in the "parking lot". That way we won't forget about it and we'll be sure to go over it in the meeting. Put your name in there so we know whose idea it is.
- End of year membership renewals are coming up:
- Send out emails: Still waiting for membership payment; Still waiting for H-Branding fee payment
- additional emails: membership about to expire, has lapsed, need more info, etc.
[Ashley] design of process conditions and slack notifications
[Ashley] any feedback about the big conference in Stockholm?
Mark as "Accept" (feature), "Deliver" (bug), or "Finished" (chore) if team agrees
- new Bug: Users/members cannot change contact e-mail
-
What needs to be specifically reviewed and refactored?
-
Status of current refactoring work
[Ashley] After the New Year, I'd like to discuss the pros and cons of using Github for issue tracking. Pro: would make the project much more public, and so would open up the possibility of having more help. Con: We'd have to figure out a new tool (one that integrates with Github).
Note items for discussion and put them in the "parking lot". That way we won't forget about it and we'll be sure to go over it in the meeting. Put your name in there so we know whose idea it is.
- Big Dog conference in Stockholm (Dec 7th):
- Goal: have Find Companies Near Me ready to demo there
- End of year membership renewals are coming up:
- Send out emails: Still waiting for membership payment; Still waiting for H-Branding fee payment
- additional emails: membership about to expire, has lapsed, need more info, etc.
[Ashley] Someone should figure out how to clean up the git develop branch. Am I doing something wrong with my PRs?
[Ashley] what happened to the vertical white space in code? I miss it.
Mark as "Accept" (feature), "Deliver" (bug), or "Finished" (chore) if team agrees
- new Bug: Users/members cannot change contact e-mail
-
What needs to be specifically reviewed and refactored?
-
Status of current refactoring work
[Ashley] After the New Year, I'd like to discuss the pros and cons of using Github for issue tracking. Pro: would make the project much more public, and so would open up the possibility of having more help. Con: We'd have to figure out a new tool (one that integrates with Github).
Note items for discussion and put them in the "parking lot". That way we won't forget about it and we'll be sure to go over it in the meeting. Put your name in there so we know whose idea it is.
- Big Dog conference in Stockholm (Dec 7th):
- Find Companies Near Me
- End of year membership renewals are coming up:
- Send out emails: Still waiting for membership payment; Still waiting for H-Branding fee payment
- additional emails: membership about to expire, has lapsed, need more info, etc.
[Ashley] No meeting 22 november? (U.S. Thanksgiving Holiday)
Mark as "Accept" (feature), "Deliver" (bug), or "Finished" (chore) if team agrees
- new Bug: Users/members cannot change contact e-mail
-
What needs to be specifically reviewed and refactored?
-
Status of current refactoring work
Note items for discussion and put them in the "parking lot". That way we won't forget about it and we'll be sure to go over it in the meeting. Put your name in there so we know whose idea it is.
- Big Dog conference in Stockholm (Dec 7th):
- Find Companies Near Me
- End of year membership renewals are coming up:
- Send out emails: Still waiting for membership payment; Still waiting for H-Branding fee payment
- additional emails: membership about to expire, has lapsed, need more info, etc.
Mark as "Accept" (feature), "Deliver" (bug), or "Finished" (chore) if team agrees
- new Bug: Users/members cannot change contact e-mail
-
What needs to be specifically reviewed and refactored?
-
Status of current refactoring work
Note items for discussion and put them in the "parking lot". That way we won't forget about it and we'll be sure to go over it in the meeting. Put your name in there so we know whose idea it is.
- review current priorities (at the bottom of today's agenda) in light of recent SHF board meeting: Where does 'Requalification' fit in the priorities now?
Mark as "Accept" (feature), "Deliver" (bug), or "Finished" (chore) if team agrees
- new Bug: Users/members cannot change contact e-mail
-
What needs to be specifically reviewed and refactored?
-
Status of current refactoring work
Top Priorities:
- Upgrade Rails - done!
- Sender name of emails - done!
- Member Requalification: Define and describe Requirements - board reviewed, will take up again in March
- Admin delete user accounts - done!
Note items for discussion and put them in the "parking lot". That way we won't forget about it and we'll be sure to go over it in the meeting. Put your name in there so we know whose idea it is.
- [Ashley] Requirements/Observer pattern as first step toward all of the 'notify user' stories?
Mark as "Accept" (feature), "Deliver" (bug), or "Finished" (chore) if team agrees
- new Bug: Users/members cannot change contact e-mail
-
What needs to be specifically reviewed and refactored?
-
Status of current refactoring work
Top Priorities:
- Upgrade Rails
- Sender name of emails
- Member Requalification: Define and describe Requirements
- Admin delete user accounts
Note items for discussion and put them in the "parking lot". That way we won't forget about it and we'll be sure to go over it in the meeting. Put your name in there so we know whose idea it is.
-
[Ashley] What's the current sprint number? Should we start with a new number? Maybe a number that has the year in it so it's obvious to anyone looking at the sprint numbers (e.g. within git) the time frame of the work?
-
[Ashley] SSL certificate - Need to install new one. Need to assign the work (PT task, etc.)
-
[Patrick] Method of allowing admin to delete a user
- Sufficient?
- Add logging as a separate story?
-
[Patrick] Accept rails upgrade PR?
Mark as "Accept" (feature), "Deliver" (bug), or "Finished" (chore) if team agrees
-
What needs to be specifically reviewed and refactored?
-
Status of current refactoring work
Top Priorities:
- Upgrade Rails
- Sender name of emails
- Member Requalification: Define and describe Requirements
- Admin delete user accounts
Note items for discussion and put them in the "parking lot". That way we won't forget about it and we'll be sure to go over it in the meeting. Put your name in there so we know whose idea it is.
Reminder: Next client meeting is Wednesday, January 17, 19:00 UTC (= 20:00 Stockholm time)
Meeting Notes
-
Attendees: Ashley, Pat
-
Issue with changing a member's association with a company (from one company to another)
- Susanna saw an exception in production when trying to do this
- We decided to:
- Fix the problem in production by a manual change in the DB (Susanna deleted a member's application and subsequently was not able to login as that user)
- Work on the longer-term problem of allowing a member to be associated with "N" (zero or more) companies
- We developed near-term and longer-term diagrams to conceptually represent the approach (Ashley will post these to the wiki)
- We created an epic, with initial stories: https://www.pivotaltracker.com/epic/show/3846829
-
Bella has requested that we provide the ability to enter user payments manually, due to one or more offline payments that have occurred.
- This raises the question as to whether our app will be the "system of record" for payments.
-
We discussed the results of reviewing destroy actions for primary models
- See: https://github.com/AgileVentures/shf-project/wiki/Model-destroy-actions-for-associated-models
- Outcome:
- We need an overall strategy for managing payment records (allow delete?, retain?). This is, of course, related to the "system of record" question noted above.
- The user model has two problems that will cause the user to see an exception:
- Deleting a user with a payment
- Deleting a user with an application
- We will need to decide how to manage records retention across the board, eventually, but for now we need to decide what to do about the user-delete problems
-
Dinkurs - discussion deferred due to more urgent matters
[Ashley] Design and code review of DinKurs Spike PR #397 after we finish with the team meeting
- identify goals (What are we trying to accomplish with the next deliverable? the ones after that...?)
- agree on basic design / approach
- define PT tasks so that work can move forward
[All] Susanna's problem with changing application for a member
- Work-around for current manifestation
- Restructuring for fully supporting this - and similar - situations
[Pat] Review model destroy actions (see wiki page)
Mark as "Accept" (feature), "Deliver" (bug), or "Finished" (chore) if team agrees
-
What needs to be specifically reviewed and refactored?
-
Status of current refactoring work
- Deleting/destroying information: Prompted by Susanna's situation (described in Slack), we need to discuss the rules about deleting things. (See notes in the wiki page: [insert here]
business rules/requirements: What historical information needs to be saved? Financial info is different than "regular" info.
- where does this fit into priorities?
Top Priorities:
- Payments: continue to monitor, work with Hips
- Proof of Membership
- DinKurs
Note items for discussion and put them in the "parking lot". That way we won't forget about it and we'll be sure to go over it in the meeting. Put your name in there so we know whose idea it is.
-
Susanna won't be able to meet on Mondays for the next x weeks. (x = 4)
-
[Ashley] DinKurs is an upcoming priority. We need to get the first part implemented. And the next step is to talk about the spike I did: PR # 397
- can we talk on Monday? Susanna cannot meet on Mondays, so she won't be there. (She's already made comments on the PR). We can talk about the technical aspects.
-
[Ashley] Technical debt! Now that we know lots more about requirements and underlying design, we have to review and revise (iterate). We need to identify and prioritize some things.
Related: tools that help us examine our code quality:-
RubyCritic https://github.com/whitesmith/rubycritic Can be run easily on local development
-
CodeClimate We can pay more attention to that. (The testing metric is now being calculated and displayed). FYI: There is a CodeClimate Chrome plug-in that shows you the scores for any code you're browsing in GitHub
-
Ashley showed the RubyCritic report for the current development branch
-
Discussion:
- we should include rubycritic gem in the development group
- When doing a PR that is refactoring, include a before and after RubyCritic report
- The important thing is to know why the scores changed in the particular context/situation. It's possible that scores may be worse afterwards if, for example, the code is being changed so that it supports future changes. Ex: the "Open/Closed" principle in SOLID is the focus or high priority for the PR. The code complexity score may worsen, but that might be expected.
-
- some PRs need 2nd reviews
- some just need updating
- [Ashley] FYI: After the email was reviewed by the client (Suss and Bella) on 3 January, Suss noticed that the content of the email needed to be changed. I marked the PT task as rejected just to see how Pivotal Tracker would handle it and how it would work in our workflow. https://www.pivotaltracker.com/story/show/153348015 (But since it was really a requirement change, it is not technically a "rejected" feature.)
Note items for discussion and put them in the "parking lot". That way we won't forget about it and we'll be sure to go over it in the meeting. Put your name in there so we know whose idea it is.
FYI We deployed after the client meeting on Tuesday
-
[Pat's PR]
-
[Ashley] When and how to review the DinKurs spike? Optimally, we would do a group walk-through and discussion to review and then come up with a good design for actual implementation. But logistics (time-zones! sleep!) may not allow for that. So -- what can we do as a globally distributed project? Perhaps I should write up a few points about my thoughts and the design? Or maybe just have a meeting (HangOut or Jitsi) with whomever can make it and go from there?
- some PRs need 2nd reviews
- some just need updating
