Only export default SES from index.js. Delete SES.js #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty to index.js instead
katelynsills
force-pushed
the
88-clean-up-index
branch
from
f14aef3 to
45a2017
Compare
warner
approved these changes
Apr 1, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BREAKING CHANGE.
This PR removes SES.js and moves its functionality into index.js to eliminate a layer of redirection. Additionally, using a default export in addition to named exports is frowned upon by our bundlers, so @warner and I decided to only do a default export. Lastly, the tests are changed to accommodate the new default export.
Closes #88