Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dist, bundler tests #97

Merged
merged 3 commits into from
Apr 1, 2019
Merged

Add dist, bundler tests #97

merged 3 commits into from
Apr 1, 2019

Conversation

katelynsills
Copy link
Contributor

@katelynsills katelynsills commented Mar 28, 2019

Description

This PR generates three different dist files with rollup - an ES6 module version, a CommonJS version, and a UMD version. These are listed under pkg.module, pkg.main, and pkg.browser respectively.

This PR adds integration tests that run automatically with CircleCI to test that SES's dist files are usable with the main JavaScript bundlers and tools. We test SES with Webpack, Browserify, Rollup, Parcel, and a mocked version of what unpkg would provide after publishing the latest version to npm. There is a README.md in /integration-test with more detailed information.

Tests

  • npm test to make sure normal tests still pass
  • npm run build to build the dist files
  • check that the dist files are ignored by git and eslint
  • npm pack to check that the dist files are included in the npm tarball
  • test the pre_release_test_integration_node_11 job locally with the CircleCI command line tool: circleci local execute --job pre_release_test_integration_node_11
  • test other CircleCI jobs in the same manner

Closes

closes #94 Closes #95 Closes #85 Closes #63

@warner
Copy link
Member

warner commented Apr 1, 2019

after #89 lands, let's rebase this (which means maybe deleting the first two commits)

@katelynsills
Copy link
Contributor Author

after #89 lands, let's rebase this (which means maybe deleting the first two commits)

Sounds good!

Copy link
Member

@warner warner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, as long as the test all still pass after rebasing it on #89 (which should land first, of course)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants