Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64:crabble-start proposal is triggering SDK rebuild #89

Closed
turadg opened this issue Feb 5, 2024 · 1 comment
Closed

64:crabble-start proposal is triggering SDK rebuild #89

turadg opened this issue Feb 5, 2024 · 1 comment

Comments

@turadg
Copy link
Member

turadg commented Feb 5, 2024

Evaluating the Crabble proposal is triggering SDK rebuild:

2024-02-05T19:02:40.6261224Z #1960 [test-upgrade-13 eval-crabble-start 6/6] RUN ./run_eval.sh 64:crabble-start
2024-02-05T19:02:40.6280827Z #1960 136.9 At least package.json is newer than node_modules
2024-02-05T19:02:40.6281232Z #1960 136.9 yarn install v1.22.19
…
2024-02-05T19:02:40.6288774Z #1960 136.9 Yarn packages need to be built
2024-02-05T19:02:40.6289111Z #1960 136.9 yarn run v1.22.19
2024-02-05T19:02:40.6289400Z #1960 136.9 $ yarn workspaces run build

That triggers rebuilding even Xsnap. Totally not necessary and flakes sometimes in the AMD build.

These were attempts to prevent that:
feat: absolute path to agd binary
chore: use unreleased synthetic-chain package

But they didn't work, as demonstrated in https://github.com/Agoric/agoric-3-proposals/actions/runs/7789170001/job/21240169503?pr=88

This might be due to something in #88 but needs further investigation

turadg added a commit that referenced this issue Feb 6, 2024
turadg added a commit that referenced this issue Feb 6, 2024
@turadg
Copy link
Member Author

turadg commented Feb 7, 2024

Fixed by a4020ce

@turadg turadg closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant