-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remote builds #88
remote builds #88
Conversation
6c959ef
to
732117c
Compare
Please mention me again when the tests are passing. Thanks! |
@michaelfig please provide your perspective on:
I don't expect any of those to change in the course of getting the tests back to green. (They were green when I first requested review) Happy to sync if more context is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- "build" command only for downstream repos
That looks good.
- reliance on "depot" and how it's factored
Also good. The CI changes look like I would have hoped.
- documentation requirements
I think things are sufficiently documented.
Nothing here looks like it needs any drastic changes, but I haven't yet tried to reproduce the build steps on my own machine, which I believe is a prerequisite for being able to give explicit approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Onward and upward!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This rename causes agoric-sdk a3p-integration tests to fail.
Sorry for not reviewing this earlier, and I'm not even sure I would have caught it, but |
closes: #85
Building all the use images in #69 takes much more disk space. The hacks to make that work broke the image merging job that had worked previously.
After exploring many options, this PR adopts Depot.dev to build remotely. Their concurrent multiplatform bake greatly simplifies the CI. It removes the need to self-host our ARM runner and the large persistent build cache greatly speeds up our builds (e.g. a JS change builds in minutes to resolve the image caches instead of over an hour to re-run all the chain operations.)
There are some other changes that should be evident from the commit messages.
Test plan
yarn test
works locally and includes unpassed proposals