Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add upgrade-16 (proposal 75) #166

Merged
merged 7 commits into from
Aug 14, 2024
Merged

feat: add upgrade-16 (proposal 75) #166

merged 7 commits into from
Aug 14, 2024

Conversation

dckc
Copy link
Member

@dckc dckc commented Aug 9, 2024 •
edited
Loading

fixes #167

Initial attempts to test locally failed at the yarn build step:

ERROR: docker exporter does not currently support exporting manifest lists
...
Instead use a builder that supports multiplatform such as depot.dev.

cc @turadg @Chris-Hibbert @LuqiPan

@turadg
Copy link
Member

turadg commented Aug 9, 2024

ERROR: docker exporter does not currently support exporting manifest lists

Remove the platforms property from package.json to build for just the local platform.

Chris-Hibbert
Chris-Hibbert reviewed Aug 12, 2024
View reviewed changes
proposals/75:upgrade-16/provisionPool.test.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think provisioning was part of U16, but provisionPool was not. (Yeah they're distinct things.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed https://github.com/Agoric/agoric-sdk/tree/dev-upgrade-16/a3p-integration/proposals/a%3Aupgrade-16

Copy link
Member Author

@dckc dckc Aug 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently I had copied from the wrong source.

I've updated the PR to copy from the right source:

https://github.com/Agoric/agoric-sdk/tree/agoric-upgrade-16/a3p-integration/proposals/a%3Aupgrade-16/

proposals/75:upgrade-16/upgradeVaults.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vaults was not included in U16

proposals/75:upgrade-16/use.sh Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not in upgrade 16

proposals/75:upgrade-16/synthetic-chain-excerpt.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double-check this. My impression was that synthetic-chain didn't make it into U16, but i'm not certain.

proposals/75:upgrade-16/exitOffer.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know whether this test pertains to U16.

@dckc
chore: copy a3p-integration from u16 branch of agoric-sdk
31c72ca 
cp -r ag-u16/a3p-integration/proposals/a\:upgrade-16/ 75:upgrade-16/

where ag-u16 is at c772ff407
@dckc
chore: fill in upgradeInfo from chain, etc.
1321dac 
 - go back to u15 structure
 - update release notes pointer; get sdkImageTag from release notes
 - get upgradeInfo from block explorer
@dckc
chore: fill in build-all-submissions.sh output
57d6e56 
a3p-integration$ ./scripts/build-all-submissions.sh
dckc
dckc commented Aug 13, 2024
View reviewed changes
proposals/75:upgrade-16/vatDetails.js
@@ -0,0 +1,100 @@
import dbOpenAmbient from 'better-sqlite3';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why this file is here. I can't find anything that imports from it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used in the vaults and auctions upgrade. I dunno whether any parts were used in orchestration upgrades.

@dckc dckc marked this pull request as ready for review August 13, 2024 15:41
@dckc
Copy link
Member Author

dckc commented Aug 13, 2024

I gather ci for this is a bit fragile. I'll try it again.

Symptoms:

  ✘ Timed out while running tests

https://github.com/Agoric/agoric-3-proposals/actions/runs/10372747065/job/28716195667?pr=166#step:11:12725

@Chris-Hibbert Chris-Hibbert mentioned this pull request Aug 13, 2024
Merged
@dckc
Copy link
Member Author

dckc commented Aug 14, 2024 •
edited
Loading

@turadg @Chris-Hibbert it's green. Please take a look.

p.s. the Timed out while running tests diagnostic wasn't hiding anything. A known-good ci log showed:

  ✔ probeZcfBundleCap › upgrade Zoe to verify ZcfBundleCap endures (39.2s)

so I raised the timeout to 60s, and that seems to do the trick.

turadg
turadg approved these changes Aug 14, 2024
View reviewed changes
proposals/75:upgrade-16/use.sh Outdated
@@ -0,0 +1,6 @@
#!/bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty. consider dropping to aid debugging in the future (clear there's no "use" stage)

@dckc dckc enabled auto-merge (rebase) August 14, 2024 20:21
Chris-Hibbert
Chris-Hibbert reviewed Aug 14, 2024
View reviewed changes
proposals/75:upgrade-16/probe-submission/probeZcfBundle-plan.json Outdated
{
"entrypoint": "@agoric/vats/src/vat-zoe.js",
"bundleID": "b1-db507028460b0c9ad9b16a1e1094b4cd09cfbdc1779c992b42d828745788d98393ca4740599ac4b2e3a6f4bd8d9018aad6d509107eced9253fe7d3c0085709a7",
"fileName": "/home/connolly/.agoric/cache/b1-db507028460b0c9ad9b16a1e1094b4cd09cfbdc1779c992b42d828745788d98393ca4740599ac4b2e3a6f4bd8d9018aad6d509107eced9253fe7d3c0085709a7.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do these local file paths on your machine matter?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They don't affect execution.

I guess cleaning them up for looks is worthwhile...

@dckc dckc disabled auto-merge August 14, 2024 20:27
@dckc dckc enabled auto-merge (rebase) August 14, 2024 20:34
@dckc dckc merged commit a1d86ab into main Aug 14, 2024
2 checks passed
@dckc dckc deleted the dc-u16 branch August 14, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chris-Hibbert Chris-Hibbert Chris-Hibbert left review comments

@turadg turadg turadg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add upgrade-16 (proposal 75) to agoric-3-proposals
3 participants
@dckc @turadg @Chris-Hibbert