Update a3p-integration after upgrade 16 #9878

Chris-Hibbert · 2024-08-12T17:42:59Z

closes: #9835
refs: Agoric/agoric-3-proposals#167

Description

Remove changes that were included in upgrade 16 from a3p-integration.

Security Considerations

N/A

Scaling Considerations

None

Documentation Considerations

None

Testing Considerations

Set up the test environment for the next phase.

Upgrade Considerations

Clean up for the next set of upgrade tests.

cloudflare-workers-and-pages · 2024-08-12T20:15:33Z

Deploying agoric-sdk with Cloudflare Pages

Latest commit:	`3ff2d5a`
Status:	✅ Deploy successful!
Preview URL:	https://87bf4c67.agoric-sdk.pages.dev
Branch Preview URL:	https://9835-a3pi-post-u16.agoric-sdk.pages.dev

View logs

turadg

b:enable-orchestration needs to stay. it wasn't part of u16. it's a separate proposal.

Regardless, c:stake-bld needn't be renamed.

a3p-integration/proposals/b:enable-orchestration/package.json

a3p-integration/proposals/README.md

Chris-Hibbert · 2024-08-13T23:50:34Z

I reverted the removal of orchestration.

I will now wait for Agoric/agoric-3-proposals#166 before merging, but a final review would be appreciated.

turadg

I won't approve until this is based on latest that includes u16. Until then it's hard to say whether the changes are valid.

Weren't these in u16?

				// Enable low-level Orchestration.
				vm.CoreProposalStepForModules(
					"@agoric/builders/scripts/vats/init-network.js",
					"@agoric/builders/scripts/vats/init-localchain.js",
					"@agoric/builders/scripts/vats/init-transfer.js",
				),

Chris-Hibbert · 2024-08-14T16:22:57Z

Weren't these in u16?

I removed those lines in upgrade.go.

I wasn't involved in orchestration. So some low level orchestration tooling was added in upgrade.go, but b:enable-orchestration was dropped. What did the latter contain? Were any tests for the orchestration tools run for U16?

turadg · 2024-08-14T18:12:31Z

b:enable-orchestration was dropped. What did the latter contain?

Starting vat-orchestration

Were any tests for the orchestration tools run for U16?

You mean the init-network, init-localchain, init-transfer? Yes, there are other tests in upgrade-next. E.g. https://github.com/Agoric/agoric-sdk/blob/master/a3p-integration/proposals/a:upgrade-next/localchain.test.js#L34

You don't need to analyze those. They'll all start failing when this PR is on top of an A3P image with u16. It's blocked on that.

Chris-Hibbert · 2024-08-14T22:40:12Z

Rerunning now with the latest latest.

turadg

failing yet on,

#27 46.52 Waiting for upgrade height for UNRELEASED_A3P_INTEGRATION to be reached (need 1119, have 1118)
#27 47.44 10:47PM ERR UPGRADE "UNRELEASED_A3P_INTEGRATION" NEEDED at height: 1119: {"coreProposals":[]}

turadg · 2024-08-15T00:56:15Z

a3p-integration/proposals/README.md

+
+Once `latest` has changed, if it was a Software Upgrade Proposal then the
+upgrade handler in master will fail.  If that poses a problem, you can set
+a3p-integration `agoricSyntheticChain.fromtTag` to a specific version instead


turadg · 2024-08-15T00:57:24Z

a3p-integration/proposals/README.md

+```
+    "releaseNotes": false,
+    "sdkImageTag": "unreleased",
+    "planName": "UNRELEASED_A3P_INTEGRATION",


I just noticed that some other docs are still pointing to UNRELEASED_UPGRADE, which wasn't updated in the docs when that string changed in #9575

this is now on a3p:latest with u16

dckc

some suggestions to consider

I think approval should wait until it's passing ci.

dckc · 2024-08-15T15:54:32Z

a3p-integration/proposals/README.md

+To build that artifact,
+```
+cd a3p-integration
+scripts/build-all-submissions.sh


This results in files with absolute filenames on the developer's machine; for example /home/connolly/.agoric/cache/b1-.... Should those be changed? Some advice one way or the other would be nice here.

dckc · 2024-08-15T15:57:10Z

a3p-integration/proposals/a:upgrade-next/provisioning.test.js

-  t.is(incarnation, 1);
-});
-
-test.serial(`send invitation via namesByAddress`, async t => {


This seems like a feature that should work in every release going forward. Deleting the test seems unfortunate.

How about migrating it to the acceptance test?

acceptance test of upgrade #8961

Punted to #8961

turadg

I implemented some innocuous changes and cleaned up the commit history to get this in to unbreak master.

turadg · 2024-08-16T16:01:02Z

@mergify update

turadg · 2024-08-16T16:01:29Z

@mergify rebase

mergify · 2024-08-16T16:01:29Z

update

✅ Branch has been successfully updated

This reverts commit c3c11be.

mergify · 2024-08-16T16:01:36Z

rebase

✅ Branch has been successfully rebased

Chris-Hibbert added test contract-upgrade next-release about next agoric-sdk or endo release labels Aug 12, 2024

Chris-Hibbert self-assigned this Aug 12, 2024

Chris-Hibbert requested review from dckc and mhofman August 12, 2024 18:13

Chris-Hibbert force-pushed the 9835-a3pi-post-u16 branch from 759d8a3 to 448bf42 Compare August 12, 2024 20:15

turadg added the force:integration Force integration tests to run on PR label Aug 13, 2024

turadg previously requested changes Aug 13, 2024

View reviewed changes

a3p-integration/proposals/b:enable-orchestration/package.json Outdated Show resolved Hide resolved

dckc reviewed Aug 13, 2024

View reviewed changes

a3p-integration/proposals/README.md Outdated Show resolved Hide resolved

Chris-Hibbert commented Aug 13, 2024

View reviewed changes

a3p-integration/proposals/README.md Outdated Show resolved Hide resolved

Chris-Hibbert force-pushed the 9835-a3pi-post-u16 branch from 2f64f57 to d47ea7d Compare August 13, 2024 23:50

Chris-Hibbert requested review from turadg and dckc August 13, 2024 23:50

turadg reviewed Aug 14, 2024

View reviewed changes

Chris-Hibbert force-pushed the 9835-a3pi-post-u16 branch from 1817736 to f764980 Compare August 14, 2024 22:38

Chris-Hibbert requested a review from turadg August 14, 2024 22:39

turadg reviewed Aug 15, 2024

View reviewed changes

dckc reviewed Aug 15, 2024

View reviewed changes

Chris-Hibbert force-pushed the 9835-a3pi-post-u16 branch from f764980 to 8126798 Compare August 15, 2024 22:09

turadg force-pushed the 9835-a3pi-post-u16 branch from 8126798 to 985c754 Compare August 16, 2024 12:22

turadg approved these changes Aug 16, 2024

View reviewed changes

turadg added the automerge:rebase Automatically rebase updates, then merge label Aug 16, 2024

turadg mentioned this pull request Aug 16, 2024

acceptance test of upgrade #8961

Open

turadg force-pushed the 9835-a3pi-post-u16 branch from 985c754 to ea761fc Compare August 16, 2024 12:28

turadg and others added 6 commits August 16, 2024 16:01

Revert "test: base a3p on upgrade-15"

6819135

This reverts commit c3c11be.

chore: repair app.go after Upgrade 16

0dbfa2d

chore: remove u16 provisioning updates from a3p-integration

c852b16

chore: remove u16 zoe upgrade from a3p-integration

dd97f18

chore: drop "enable low-level Orchestration"

e7623af

docs: a3p draft proposals

3ff2d5a

turadg force-pushed the 9835-a3pi-post-u16 branch from 8edbd18 to 3ff2d5a Compare August 16, 2024 16:01

mergify bot merged commit de95355 into master Aug 16, 2024
82 checks passed

mergify bot deleted the 9835-a3pi-post-u16 branch August 16, 2024 16:34

turadg mentioned this pull request Sep 9, 2024

migrate existing tests from previous upgrades to z:acceptance #10049

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update a3p-integration after upgrade 16 #9878

Update a3p-integration after upgrade 16 #9878

Chris-Hibbert commented Aug 12, 2024

cloudflare-workers-and-pages bot commented Aug 12, 2024 •

edited

Loading

turadg left a comment

Chris-Hibbert commented Aug 13, 2024

turadg left a comment

Chris-Hibbert commented Aug 14, 2024

turadg commented Aug 14, 2024

Chris-Hibbert commented Aug 14, 2024

turadg left a comment •

edited

Loading

turadg Aug 15, 2024

turadg Aug 15, 2024

dckc left a comment

dckc Aug 15, 2024

dckc Aug 15, 2024

turadg Aug 16, 2024

turadg left a comment

turadg commented Aug 16, 2024

turadg commented Aug 16, 2024

mergify bot commented Aug 16, 2024

mergify bot commented Aug 16, 2024

Update a3p-integration after upgrade 16 #9878

Update a3p-integration after upgrade 16 #9878

Conversation

Chris-Hibbert commented Aug 12, 2024

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

cloudflare-workers-and-pages bot commented Aug 12, 2024 • edited Loading

Deploying agoric-sdk with Cloudflare Pages

turadg left a comment

Choose a reason for hiding this comment

Chris-Hibbert commented Aug 13, 2024

turadg left a comment

Choose a reason for hiding this comment

Chris-Hibbert commented Aug 14, 2024

turadg commented Aug 14, 2024

Chris-Hibbert commented Aug 14, 2024

turadg left a comment • edited Loading

Choose a reason for hiding this comment

turadg Aug 15, 2024

Choose a reason for hiding this comment

turadg Aug 15, 2024

Choose a reason for hiding this comment

dckc left a comment

Choose a reason for hiding this comment

dckc Aug 15, 2024

Choose a reason for hiding this comment

dckc Aug 15, 2024

Choose a reason for hiding this comment

turadg Aug 16, 2024

Choose a reason for hiding this comment

turadg left a comment

Choose a reason for hiding this comment

turadg commented Aug 16, 2024

turadg commented Aug 16, 2024

mergify bot commented Aug 16, 2024

✅ Branch has been successfully updated

mergify bot commented Aug 16, 2024

✅ Branch has been successfully rebased

cloudflare-workers-and-pages bot commented Aug 12, 2024 •

edited

Loading

turadg left a comment •

edited

Loading