odd {x, y, z} >= {z} failure in AmountMath.isGTE with AssetKind.SET

[dckc]

Describe the bug

AmountMath.isGTE with AssetKind.SET fails in a case involving invitations with common descriptions but distinct instance handles.

To Reproduce

Add this to packages/ERTP/test/unitTests/mathHelpers/copySetMathHelpers.test.js and run it:

test('balance {x, y, z} >= {z}', t => {
  const x = { instance: mockHandle('Foo'), description: 'fraz' };
  const y = { instance: mockHandle('Foo'), description: 'fraz' };
  const z = { instance: mockHandle('Foo'), description: 'alan' };

  const balance = harden({ brand: mockBrand, value: makeCopySet([x, y, z]) });
  const withdraw = harden({ brand: mockBrand, value: makeCopySet([z]) });

  t.true(m.isGTE(balance, withdraw));
});

Expected behavior

test above passes

Platform Environment

375dc25

Additional context

@frazarshad discovered this while working on

• test(a3p): create a3p test for replace electorate core eval #10241

He made a test PR, #10281

a ci log of that a3p test shows the original context where the problem was found

more diagnosis an an endo issue to follow

Screenshots / Logs

since ci logs expire:

2024-10-16T13:03:13.026Z SwingSet: ls: v9: Error#1: Withdrawal of { brand: Object [Alleged: Zoe Invitation brand] {}, value: [ { description: 'charter member invitation', handle: Object [Alleged: InvitationHandle] {}, installation: Object [Alleged: BundleIDInstallation] {}, instance: Object [Alleged: InstanceHandle] {} } ] } failed because the purse only contained { brand: Object [Alleged: Zoe Invitation brand] {}, value: [ { description: 'charter member invitation', handle: Object [Alleged: InvitationHandle] {}, installation: Object [Alleged: BundleIDInstallation] {}, instance: Object [Alleged: InstanceHandle] {} }, { description: 'oracle invitation', handle: Object [Alleged: InvitationHandle] {}, installation: Object [Alleged: BundleIDInstallation] {}, instance: Object [Alleged: InstanceHandle] {} }, { description: 'oracle invitation', handle: Object [Alleged: InvitationHandle] {}, installation: Object [Alleged: BundleIDInstallation] {}, instance: Object [Alleged: InstanceHandle] {} }, { description: 'Voter0', handle: Object [Alleged: InvitationHandle] {}, installation: Object [Alleged: BundleIDInstallation] {}, instance: Object [Alleged: InstanceHandle] {} } ] }

[dckc]

The original failure was observed in a withdraw:

agoric-sdk/packages/smart-wallet/src/invitations.js

Line 140 in 94aaebc

return E(invitationsPurse).withdraw(toWithDraw);

We can see that the amount withdrawn is derived from the balance by filtering:

agoric-sdk/packages/smart-wallet/src/invitations.js

Lines 112 to 140 in 94aaebc

	const purseAmount = await E(invitationsPurse).getCurrentAmount();
	const invitations = AmountMath.getValue(invitationBrand, purseAmount);
	const matches = invitations.filter(
	details =>
	description === details.description && instance === details.instance,
	);
	if (matches.length === 0) {
	// look up diagnostic info
	const dCount = invitations.filter(
	details => description === details.description,
	).length;
	const iCount = invitations.filter(
	details => instance === details.instance,
	).length;
	assert.fail(
	`no invitation match (${dCount} description and ${iCount} instance)`,
	);
	} else if (matches.length > 1) {
	// TODO? allow further disambiguation
	console.warn('multiple invitation matches, picking the first');
	}
	const match = matches[0];
	const toWithDraw = AmountMath.make(invitationBrand, harden([match]));
	console.log('.... ', { toWithDraw });
	return E(invitationsPurse).withdraw(toWithDraw);

interleaving is theoretically possible, but that would have shown in logs, and it doesn't.

[dckc]

fixed in #10316

for upgrade of the zoe invitation issuer, see #10279