Turn priceFeed proposal into a SoftwareUpgrade #10317
Conversation
Chris-Hibbert
added
contract-upgrade
oracle
Chris-Hibbert
changed the base branch from
master
to
fraz/replace-committee-a3p
There was a problem hiding this comment.
priceFeedUpdate.test.js etc. seems like adequate test coverage. I did manage to summon attention to study the code in as much detail as I'd like, but I recognize a lot of the patterns, and if the tests pass, I'm reasonably confident that it's good.
I much prefer that #10317 is merged first. I expect @frazarshad can get that done in the next day.
Merging this into fraz/replace-committee-a3p will complicate review of #10317; I'd rather we don't do that, but I find it acceptable.
| const config = configurations[opts.variant]; | ||
| if (!config) { | ||
| console.error(Usage); | ||
| process.exit(1); |
There was a problem hiding this comment.
suggestion:
having process.exit() someplace other than the main function makes me uncomfortable. I'd rather see throw here.
Deploying agoric-sdk with
|
| Latest commit: |
a109395
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1987fbab.agoric-sdk.pages.dev |
| Branch Preview URL: | https://9370-pricefeed-swupgrade.agoric-sdk.pages.dev |
frazarshad
force-pushed
the
fraz/replace-committee-a3p
branch
from
56f8b3c to
f406d25
Compare
Chris-Hibbert
force-pushed
the
9370-priceFeed-swUpgrade
branch
from
8bbef33 to
b953eae
Compare
|
cc: @frazarshad |
LGTM 👍 |
Chris-Hibbert
added
the
automerge:rebase
extracted getVariantFromUpgradeName
The vaults upgrade consumed instance.auctioneer and compared it to the new instance, passed from the new auctioneer proposal in a single-use promise, and failed if they weren't different. In this software upgrade, the instance.auctioneer value might be the new value, so this test can fail. Since the single-use promise comes directly from the new auction proposal, if it has a value, it's the new one.
Why didn't it complain earlier?
I added replaceElectorate.js, so it wouldn't be run a second time by yarn ava ./*.test.js but that caused it to not in CI be found for yarn ava ./replaceElectorate.test.js which seems bizarre to me
Chris-Hibbert
force-pushed
the
9370-priceFeed-swUpgrade
branch
from
33c5460 to
a109395
Compare
closes: #9370
Description
The priceFeed proposal has been tested as an independent coreEval, but the current plan calls for it to be included in Upgrade 18. This adds it to
upgrade.goand moves the tests ton:upgrade-next.Security Considerations
No additional security implications.
Scaling Considerations
Addresses pre-existing scaling concerns (see #8400), and adds no new scaling issues.
Documentation Considerations
None
Testing Considerations
An existing test is moved to a new location.
The current version seems to tickle #10292, so tests may not pass at this point.
Upgrade Considerations
Targeted for upgrade 18.