Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify core proposals in upgrade handler #8843

Closed
mhofman opened this issue Jan 30, 2024 · 0 comments · Fixed by #8844
Closed

Specify core proposals in upgrade handler #8843

mhofman opened this issue Jan 30, 2024 · 0 comments · Fixed by #8844
Assignees
Labels
enhancement New feature or request

Comments

@mhofman
Copy link
Member

mhofman commented Jan 30, 2024

What is the Problem Being Solved?

#8112 added support to run core proposals during a chain software upgrade, however it relies on specifying the core proposals as part of the upgrade info when proposing an upgrade to a governance vote. That means the proposer needs to specify both the upgrade name, and the core proposal info, even though they're all distributed in a single software release.

We'd like to remove this need, and add the ability to specify core proposal info in the upgrade handler

Description of the Design

Add a helper which can be used by the golang upgrade handler to:

  • parse coreProposals from the upgradeInfo, if any
  • merge some base proposals specified by the upgrade handler

This could be a straightforward port of the equivalent logic added in #8370

Security Considerations

None

Scaling Considerations

None

Test Plan

a3p-integration

Upgrade Considerations

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant