Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade-14 fixups #8838

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Upgrade-14 fixups #8838

merged 4 commits into from
Feb 7, 2024

Conversation

mhofman
Copy link
Member

@mhofman mhofman commented Jan 29, 2024

refs: #8755

Now layered on top of #8842

Description

Fixup a couple issues from #8755

And a new feature:

Security Considerations

None

Scaling Considerations

None

Documentation Considerations

None

Testing Considerations

Existing CI tests

Upgrade Considerations

Forces the wallet factory upgrade as part of the chain upgrade handler

@mhofman mhofman added the force:integration Force integration tests to run on PR label Jan 29, 2024
@mhofman mhofman requested a review from turadg January 29, 2024 22:05
@mhofman
Copy link
Member Author

mhofman commented Jan 29, 2024

Putting back in draft until Agoric/agoric-3-proposals#85 is fixed

@mhofman mhofman marked this pull request as draft January 29, 2024 22:34
@mhofman mhofman changed the base branch from dev-upgrade-14 to mhofman/8843-core-proposal-upgrade-handler January 30, 2024 23:02
@mhofman mhofman changed the base branch from mhofman/8843-core-proposal-upgrade-handler to mhofman/some-upgrade-14-cherry-pick January 30, 2024 23:03
@mhofman mhofman force-pushed the mhofman/some-upgrade-14-cherry-pick branch from 4b0644c to b350c41 Compare January 30, 2024 23:27
@mhofman mhofman force-pushed the mhofman/fix-up-upgrade-14 branch 2 times, most recently from 38c173e to c10274c Compare January 31, 2024 22:28
@mhofman mhofman marked this pull request as ready for review January 31, 2024 22:35
@mhofman
Copy link
Member Author

mhofman commented Jan 31, 2024

PTAL @turadg

I am generating a use-upgrade-13 tag manually in https://github.com/Agoric/agoric-3-proposals/actions/runs/7733007365 in order to unblock from Agoric/agoric-3-proposals#85

@mhofman mhofman requested a review from turadg January 31, 2024 23:28
Base automatically changed from mhofman/some-upgrade-14-cherry-pick to dev-upgrade-14 February 1, 2024 19:10
@mhofman mhofman merged commit 0a0580c into dev-upgrade-14 Feb 7, 2024
63 checks passed
@mhofman mhofman deleted the mhofman/fix-up-upgrade-14 branch February 7, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants