Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade-14 fixups #8838

Merged
merged 4 commits into from
Feb 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion a3p-integration/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"agoricSyntheticChain": {
"fromTag": "upgrade-13"
"fromTag": "use-upgrade-13"
},
"scripts": {
"build": "./node_modules/.bin/synthetic-chain build",
Expand Down
5 changes: 5 additions & 0 deletions a3p-integration/proposals/a:upgrade-14/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Proposal to upgrade the chain software to upgrade-14

This software upgrade executes core proposals during the upgrade block, as
defined by the `agoric-upgrade-14` upgrade handler. See `upgrade14Handler` in
`agoric-sdk/golang/cosmos/app/app.go`
6 changes: 1 addition & 5 deletions a3p-integration/proposals/a:upgrade-14/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,7 @@
"releaseNotes": "https://github.com/Agoric/agoric-sdk/releases/tag/agoric-upgrade-14",
"sdkImageTag": "unreleased",
"planName": "agoric-upgrade-14",
"upgradeInfo": {
"coreProposals": [
"@agoric/vats/scripts/build-wallet-factory2-upgrade.js"
]
},
"upgradeInfo": {},
turadg marked this conversation as resolved.
Show resolved Hide resolved
"type": "Software Upgrade Proposal"
},
"type": "module",
Expand Down
11 changes: 6 additions & 5 deletions golang/cosmos/app/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -782,11 +782,11 @@ func NewAgoricApp(

app.UpgradeKeeper.SetUpgradeHandler(
upgradeName,
upgrade13Handler(app, upgradeName),
upgrade14Handler(app, upgradeName),
)
app.UpgradeKeeper.SetUpgradeHandler(
upgradeNameTest,
upgrade13Handler(app, upgradeNameTest),
upgrade14Handler(app, upgradeNameTest),
)

upgradeInfo, err := app.UpgradeKeeper.ReadUpgradeInfoFromDisk()
Expand Down Expand Up @@ -824,15 +824,16 @@ func NewAgoricApp(
return app
}

// upgrade13Handler performs standard upgrade actions plus custom actions for upgrade-14.
func upgrade13Handler(app *GaiaApp, targetUpgrade string) func(sdk.Context, upgradetypes.Plan, module.VersionMap) (module.VersionMap, error) {
// upgrade14Handler performs standard upgrade actions plus custom actions for upgrade-14.
func upgrade14Handler(app *GaiaApp, targetUpgrade string) func(sdk.Context, upgradetypes.Plan, module.VersionMap) (module.VersionMap, error) {
return func(ctx sdk.Context, plan upgradetypes.Plan, fromVm module.VersionMap) (module.VersionMap, error) {
app.CheckControllerInited(false)

// Each CoreProposalStep runs sequentially, and can be constructed from
// one or more modules executing in parallel within the step.
CoreProposalSteps := []vm.CoreProposalStep{
// vm.CoreProposalStepForModules("@agoric/builders/scripts/vats/init-network.js"),
// First, upgrade wallet factory
vm.CoreProposalStepForModules("@agoric/vats/scripts/build-wallet-factory2-upgrade.js"),
}

app.upgradeDetails = &upgradeDetails{
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

Loading