Core proposals in upgrade handler #8844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
changed the title
mhofman
force-pushed
the
mhofman/8843-core-proposal-upgrade-handler
branch
from
9d52b1e
to
eb9ad28
Compare
mhofman
added a commit
that referenced
this pull request
Jan 30, 2024
mhofman
added a commit
that referenced
this pull request
Jan 30, 2024
michaelfig
approved these changes
Jan 31, 2024
golang/cosmos/app/app.go
Outdated
| // Core proposals that should run during the upgrade block | ||
| // These will be merged with any coreProposals specified in the | ||
| // upgradeInfo field of the upgrade plan ran as subsequent steps | ||
| CoreProposals: vm.CoreProposalsFromSteps(), |
There was a problem hiding this comment.
Can you supply a commented-out example of what real-world use would look like? I was confused by thinking that somehow vm.CoreProposalsFromSteps() was actually supposed to do something useful, rather than just generating an emptyish struct.
golang/cosmos/vm/core_proposals.go
Outdated
There was a problem hiding this comment.
Would be nice to have tests, but I recognize that may be infeasible due to time constraints.
mhofman
force-pushed
the
mhofman/8843-core-proposal-upgrade-handler
branch
from
fa66528
to
0a4a43c
Compare
mhofman
force-pushed
the
mhofman/8843-core-proposal-upgrade-handler
branch
from
0a4a43c
to
605eb4b
Compare
mhofman
added a commit
that referenced
this pull request
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8843
Description
Adds the ability to define core proposals as part of the upgrade handler.
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
Some contributors documentation will be included in the release process
Testing Considerations
Upgrade Considerations
This change add new capabilities to our upgrade handler.