-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): upgrade Ava to 4.2 #5201
Conversation
df26b7f
to
d0caf5c
Compare
Last hurdle here seems to be this error in integration tests with dapps,
which seems to be avajs/ava#2946 (comment) @kriskowal any ideas? |
This does indeed look like the same problem others are having on the new versions of AVA. It doesn’t seem to be interference with hardened JavaScript and it’s hard to imagine it being related to the other things we’ve seen where VS Code debugger tampering with the Node.js environment when a debugger is attached. I’m at a loss. |
My current hypothesis for the failures are that it's conflicting versions of Ava due to this line in the failing tests:
That package (in this PR) is using Ava 4 and the dapps are on Ava 3. I think we need to decouple the Ava versions. cc @michaelfig #5244 may help. |
One solution may be to make a new |
closes: #4895
Upgrade Ava to latest (4.2) and make it work.
Changes:
TODO