-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove logs from test failure summary #3013
Conversation
Also update .log files in test-tap.
Used `UPDATE_REPORTER_LOG=true npx tap test-tap/reporters/*` to update them.
Using https://volta.sh/:
I've pushed those updates. |
@@ -515,9 +515,6 @@ export default class Reporter { | |||
|
|||
writeFailure(event) { | |||
this.lineWriter.writeLine(colors.title(this.prefixTitle(event.testFile, event.title))); | |||
if (!this.writeLogs(event, true)) { | |||
this.lineWriter.writeLine(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the diff, I think we need this empty line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added the empty line. According to the existing logic, an empty line will be added when there are no logs.
Thanks @il3ven! |
As per #2963 (comment), this amateur PR attempts to remove logs from the test failure summary. Closes #2963
Output before this PR
Output after this PR