Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove start-local-chain #7914

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

remove start-local-chain #7914

wants to merge 2 commits into from

Conversation

turadg
Copy link
Member

@turadg turadg commented Jun 9, 2023

closes: #7496

Description

That script was a stop gap and the gap has since been closed by boostrapTests and Docker upgrade tests.

This PR removes the script and the non-CI smoketests that depended on it.

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

  • update oracle README to point to a different integration test script

Testing Considerations

CI suffices

turadg added 2 commits June 9, 2023 12:56
We have most of this covered elsewhere, running in CI
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

speaking for myself only, I support removing this in favor of make run in upgrade-test.

I trust you'll do whatever other coordination is in order, @turadg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove start-local-chain.sh
2 participants