introduce vm-config package to fix local-npm test #8141
Conversation
.github/workflows/integration.yml
Outdated
| @@ -127,6 +127,7 @@ jobs: | |||
| - name: run agoric-cli integration-test | |||
| working-directory: ./packages/agoric-cli | |||
| run: yarn integration-test | |||
| timeout-minutes: 40 | |||
There was a problem hiding this comment.
Let's move this at the job level instead of this individual step
There was a problem hiding this comment.
I think it's worth waiting on review by @michaelfig for approval.
Meanwhile, some observations / questions.
packages/vm-config/README.md
Outdated
|
|
||
| The configs themselves have no dependencies. Keeping them separate allows packages to depend on them without depending on the world. | ||
|
|
||
| # Future plans |
There was a problem hiding this comment.
Plans seem like they belong in issues. Or at least: when we say "we plan to X" I prefer that X is linked to an issue.
And historical info ("Factored out...") belongs in commit messages.
There was a problem hiding this comment.
not firm enough plans to merit an issue, imo. if it can't be here I would just drop it.
I could qualify this with "possible future directions"
There was a problem hiding this comment.
if it can't be here
It's not a critical thing. I just wonder about it getting out of date. I get the impression that it's likely to be addressed soon anyway.
| "lint": "run-s --continue-on-error lint:*", | ||
| "lint:types": "tsc -p jsconfig.json", | ||
| "lint:eslint": "eslint ." |
There was a problem hiding this comment.
Our docs on making a new package say:
populate a new
packages/zoe/package.json, using other packages as a template
Is there any more to it than that? I'm sometimes overwhelmed wondering which other packages to use as a template.
There was a problem hiding this comment.
Those docs are a little stale. e.g. we don't have to manually add to workspaces now because it has a globl.
I'll try to update in this PR.
as a template I used boot/packages.json (i actually copied the whole dir then cut it down)
|
|
||
| This is similar to `@agoric/boot` but because that has the integration testing of bootstrap, it depends on almost everything. | ||
|
|
||
| The configs themselves have no dependencies. Keeping them separate allows packages to depend on them without depending on the world. |
There was a problem hiding this comment.
This seems like useful justification.
But I wonder to what extent it's true. The configs do reference other packages:
"coreProposals": [
"@agoric/vats/scripts/init-core.js",
"@agoric/vats/scripts/init-network.js",
{
"module": "@agoric/inter-protocol/scripts/init-core.js",There was a problem hiding this comment.
yeah… in a way it's not true. It's only true in the way that you can get the package without any other dependencies.
There was a problem hiding this comment.
thinking more, this is fully true. the configs have no dependencies. the runtime that wants to build or execute those configs does.
turadg
force-pushed
the
fix-local-npm-test
branch
from
8c99191 to
b50f7a9
Compare
often takes 20min in production. allow 40 for future cases (e.g. Endo)
turadg
force-pushed
the
fix-local-npm-test
branch
from
23ba708 to
cfad735
Compare
turadg
force-pushed
the
fix-local-npm-test
branch
from
cfad735 to
b22eef1
Compare
turadg
dismissed
mhofman’s stale review
it was just for moving the github action value, which is done
| @@ -55,7 +55,7 @@ make scenario2-setup-nobuild >>"$CHAIN_LOG" 2>&1 | |||
| echo "Starting the chain..." | |||
| # use -economy target to get the kitchen sink | |||
| # disable pruning to keep all history https://docs.desmos.network/fullnode/overview/ | |||
| make AGC_START_ARGS="--pruning=nothing" CHAIN_BOOTSTRAP_VAT_CONFIG=@agoric/boot/decentral-itest-vaults-config.json scenario2-run-chain >>"$CHAIN_LOG" 2>&1 & | |||
| make AGC_START_ARGS="--pruning=nothing" CHAIN_BOOTSTRAP_VAT_CONFIG=@agoric/vm-config/decentral-itest-vaults-config.json scenario2-run-chain >>"$CHAIN_LOG" 2>&1 & | |||
There was a problem hiding this comment.
Does this (and the reference in test-proposal-stuff.js) mean that inter-protocol/package.json should take a dependency on @agoric/vm-config?
There was a problem hiding this comment.
I don't think so, because this is instructing cosmic-swingset what to do. That's the package that really has the dependency. Same as how the JSONs in vm-config that specify a slate of packages doesn't itself depend on them (the thing that reads their source does).
Also this script is not long for this world #7914
introduce vm-config package to fix local-npm test
Description
#8102 broke the some agoric-cli integration tests.
(https://github.com/Agoric/agoric-sdk/actions/runs/5753924697/job/15598129426 )
#8140 helped but there was one problem left with resolving the configs.
This fixes that by separating configs to their own package.
It also adds a timeout and fixes a benchmark test missed in the 'boot' move.
Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
I don't think these are documented outside the repo.
Testing Considerations
Improves factoring
Upgrade Considerations
The configs are only used in bootstrap, not upgrade.