-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce vm-config package to fix local-npm test #8141
Changes from all commits
c3b3b5f
d337987
8b1ecad
440e62e
97d4ec5
64a1b66
b22eef1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,3 @@ | ||
// @ts-check | ||
// Ambient types | ||
import '@agoric/vats/src/core/types.js'; | ||
import '@agoric/zoe/src/contractFacet/types.js'; | ||
import '@agoric/zoe/src/types.js'; | ||
import '@agoric/zoe/tools/types-ambient.js'; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# VM Config | ||
|
||
Factored out of @agoric/vats, by way of @agoric/boot. | ||
|
||
This is similar to `@agoric/boot` but because that has the integration testing of bootstrap, it depends on almost everything. | ||
|
||
The configs themselves have no dependencies. Keeping them separate allows packages to depend on them without depending on the world. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems like useful justification. But I wonder to what extent it's true. The configs do reference other packages: "coreProposals": [
"@agoric/vats/scripts/init-core.js",
"@agoric/vats/scripts/init-network.js",
{
"module": "@agoric/inter-protocol/scripts/init-core.js", There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah… in a way it's not true. It's only true in the way that you can get the package without any other dependencies. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thinking more, this is fully true. the configs have no dependencies. the runtime that wants to build or execute those configs does. |
||
|
||
# Future ideas | ||
|
||
- [ ] move some things from agoric/vats to agoric/boot (needed only to bootstrap) | ||
- [ ] move authorityViz to vm-config | ||
- [ ] consider moving defaultBootstrapVatConfig out of cosmic-swingset (by making sim-chain configurable) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this (and the reference in
test-proposal-stuff.js
) mean thatinter-protocol/package.json
should take a dependency on@agoric/vm-config
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, because this is instructing
cosmic-swingset
what to do. That's the package that really has the dependency. Same as how the JSONs in vm-config that specify a slate of packages doesn't itself depend on them (the thing that reads their source does).Also this script is not long for this world #7914