-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cosmic-swingset): only require vatconfig if uninitialized #8140
Conversation
f8db963
to
cfb72f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems legit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clear fix and nice adjacent cleanup.
I'm having problems with the getting-started local-npm test, so I manually removed from the merge queue:
|
Thanks to @turadg for helping me wrangle some ambient types. This should pass now. |
fix(cosmic-swingset): only require vatconfig if uninitialized
refs: #8102
Description
This PR removes an unnecessary runtime dependency on the static SwingSet config file. It is used only for bootstrap, so its absence (or modification) in a future upgrade does not affect the operation of the SwingSet. Cosmic-swingset was searching for this file on every restart, which meant that part of the reorganization intended by #8102 prevented the chain from restarting:
As #8102 intended, this PR also removes the redundant copies of the swingset configs from
@agoric/vats/decentral*.json
.Security Considerations
Makes existing SwingSet instances more robust to future bootstrap config modifications.
Scaling Considerations
n/a
Documentation Considerations
n/a
Testing Considerations
Tested by upgrade-tests.
Upgrade Considerations
Removes an unnecessary dependency, enabling upgrade to be more successful.