fix(provisioning): export useful namesByAddress (release branch) #8786

dckc · 2024-01-22T18:37:09Z

closes: #8311
this fix is for the release branch, anyway.
see #8821 for fix on master

DRAFT until:

e2e test that namesByAddress works for delivering stuff
figure out how to get CI to run
review bootstrap for consumers of namesByAddress
figure out end-to-end testing infrastructure and release branch stuff
- stacked on: port "add a CoreEval to a3p-integration" to release branch (WIP) #8819
- see also: feat(names-by-addr): test provisioning vat upgrade agoric-3-proposals#76

Description

The namesByAddress provided by the provisioning vat is disconnected from namesByAddressAdmin, so it never gets populated.

Fortunately, the relevant nameHubKit is in baggage. So the fix here is to return that one.

Security Considerations

This should make it unnecessary for future core-eval scripts to get the whole namesByAddressAdmin authority when they only need namesByAddress to do something like deliver fees.

The permit of the upgrade core-eval is:

      consume: {
        vatStore: true,
        vatAdminSvc: true,
      },
      produce: {
        namesByAddress: true,
      },

Read/write access to the whole vatStore is excess authority; we only need access to read one of its entries, not authority to scribble over all the others and upgrade all the other vats.
vatAdminSvc is needed to look up a bundleID (hash) and return the corresponding bundleCap. Its only method beyond that sort of bundle lookup is E(vatAdminSvc).createVat(). That method is more than we need, but while it can be wasteful, it doesn't pose any risk to integrity.

Scaling Considerations

n/a

Documentation Considerations

fixes the chain to agree with our docs on name services

Testing Considerations

see DRAFT until list above

Upgrade Considerations

The bug is localized to the provisioning vat, so upgrading it seems to suffice.

Perhaps we should fix #8408 while we're at it?

dckc · 2024-01-22T18:53:31Z

seems to work...

I wonder what all the failed deposit to stATOM-USD price feed member are about. I hope it's left over from experimenting with other things on this local chain.

ag-power-tools-agd-1  | 2024-01-22T18:30:57.130Z SwingSet: vat: v1: evaluateBundleCap { manifestBundleRef: { bundleID: 'b1-af71cf8c6c422525b406913a427b6d6afe93bd29929f64a5e115da0913f37342931ac58abf3a60f5144ae642e285544abec2e637312d3f8802f13e401346af5b' }, exportedGetManifest: 'getManifestForProvisioning', vatAdminSvc: Promise [Promise] {} }
ag-power-tools-agd-1  | 2024-01-22T18:30:57.182Z SwingSet: vat: v1: execute { exportedGetManifest: 'getManifestForProvisioning', behaviors: [ 'getManifestForProvisioning', 'upgradeProvisioningVat' ] }
ag-power-tools-agd-1  | 2024-01-22T18:30:57.183Z SwingSet: vat: v1: coreProposal: upgradeProvisioningVat
ag-power-tools-agd-1  | 2024-01-22T18:30:57.183Z SwingSet: vat: v1: upgradeProvisioningVat...
ag-power-tools-agd-1  | 2024-01-22T18:30:57.184Z SwingSet: vat: v1: provisioning { adminNode: Object [Alleged: adminNode] {}, root: Object [Alleged: undefined] {} } b1-c40cda8e60deec8147a547ccfda551398056d69280edbf345e25f75c7943cd3b597637b9761ceb9d3e4690721be69dd4f493bab39177dbd98ee9633a41549f8d
ag-power-tools-agd-1  | 2024-01-22T18:30:58.039Z SwingSet: kernel: vat v11 upgraded from incarnation 0 to 1 with source b1-c40cda8e60deec8147a547ccfda551398056d69280edbf345e25f75c7943cd3b597637b9761ceb9d3e4690721be69dd4f493bab39177dbd98ee9633a41549f8d
ag-power-tools-agd-1  | 2024-01-22T18:30:58.043Z SwingSet: vat: v1: failed deposit to stATOM-USD price feed member agoric1ldmtatp24qlllgxmrsjzcpe20fvlkp448zcuce { incarnationNumber: 0, name: 'vatUpgraded', upgradeMessage: 'fix namesByAddress' }
ag-power-tools-agd-1  | 2024-01-22T18:30:58.044Z SwingSet: vat: v1: failed deposit to stATOM-USD price feed member agoric140dmkrz2e42ergjj7gyvejhzmjzurvqeq82ang { incarnationNumber: 0, name: 'vatUpgraded', upgradeMessage: 'fix namesByAddress' }
ag-power-tools-agd-1  | 2024-01-22T18:30:58.046Z SwingSet: vat: v1: failed deposit to stATOM-USD price feed member agoric1w8wktaur4zf8qmmtn3n7x3r0jhsjkjntcm3u6h { incarnationNumber: 0, name: 'vatUpgraded', upgradeMessage: 'fix namesByAddress' }
ag-power-tools-agd-1  | 2024-01-22T18:30:58.047Z SwingSet: vat: v1: failed deposit to stATOM-USD price feed member agoric10vjkvkmpp9e356xeh6qqlhrny2htyzp8hf88fk { incarnationNumber: 0, name: 'vatUpgraded', upgradeMessage: 'fix namesByAddress' }
ag-power-tools-agd-1  | 2024-01-22T18:30:58.049Z SwingSet: vat: v1: failed deposit to stATOM-USD price feed member agoric1qj07c7vfk3knqdral0sej7fa6eavkdn8vd8etf { incarnationNumber: 0, name: 'vatUpgraded', upgradeMessage: 'fix namesByAddress' }
ag-power-tools-agd-1  | 2024-01-22T18:30:58.050Z SwingSet: vat: v1: failed deposit to stATOM-USD price feed member agoric1lw4e4aas9q84tq0q92j85rwjjjapf8dmnllnft { incarnationNumber: 0, name: 'vatUpgraded', upgradeMessage: 'fix namesByAddress' }
ag-power-tools-agd-1  | 2024-01-22T18:30:58.051Z SwingSet: vat: v1: failed deposit to stATOM-USD price feed member agoric1ra0g6crtsy6r3qnpu7ruvm7qd4wjnznyzg5nu4 { incarnationNumber: 0, name: 'vatUpgraded', upgradeMessage: 'fix namesByAddress' }
ag-power-tools-agd-1  | 2024-01-22T18:30:58.052Z SwingSet: vat: v1: failed deposit to stATOM-USD price feed member agoric1zj6vrrrjq4gsyr9lw7dplv4vyejg3p8j2urm82 { incarnationNumber: 0, name: 'vatUpgraded', upgradeMessage: 'fix namesByAddress' }
ag-power-tools-agd-1  | 2024-01-22T18:30:58.053Z SwingSet: vat: v1: failed deposit to stATOM-USD price feed member agoric15xddzse9lq74cyt6ev9d7wywxerenxdgxsdc3m { incarnationNumber: 0, name: 'vatUpgraded', upgradeMessage: 'fix namesByAddress' }
ag-power-tools-agd-1  | 2024-01-22T18:30:58.054Z SwingSet: vat: v1: failed deposit to stATOM-USD price feed member agoric1w5wmck6q2xrt20ax3njlk2k87m4t4l2y2xgw2d { incarnationNumber: 0, name: 'vatUpgraded', upgradeMessage: 'fix namesByAddress' }
ag-power-tools-agd-1  | 2024-01-22T18:30:58.058Z SwingSet: vat: v1: { name: 'provisioning', opts: { upgradeMessage: 'fix namesByAddress' }, incarnation: { incarnationNumber: 1 } }
ag-power-tools-agd-1  | 2024-01-22T18:30:58.236Z SwingSet: vat: v1: namesByAddress: new Promise
ag-power-tools-agd-1  | 2024-01-22T18:30:58.237Z SwingSet: vat: v1: namesByAddress settled; remaining: [ 'anchorKits', 'bankMints', 'contractGovernor', 'reserveGovernorCreatorFacet', 'scaledPriceAuthorityKits', 'vBankKits', 'vaultFactoryGovernorCreator' ]

dckc · 2024-01-23T00:16:04Z

review bootstrap for consumers of namesByAddress

I reviewed all occurrences of namesByAddress in the current SDK; unless there's something sneaky and dynamic going on, no production contracts nor vats are holding on to the old one.

`namesByAddress` supplied by the provisioning vat was an independent NameHub from `namesByAddressAdmin`.

- run core-eval to replace provisioning vat - test incarnation - functional test

dckc · 2024-01-26T06:11:13Z

@turadg please take a look. It's draft only because it's stacked on #8819 , my work-in-progress port of a3p-integration with "simplify core-eval" to a release branch context.

@mhofman perhaps you've got thoughts on how this should land in the release branch.

cc @Chris-Hibbert who is doing similar stuff.

See also #8821 for the corresponding fix for master, especially the testing considerations.

turadg · 2024-01-26T21:50:53Z

a3p-integration/proposals/c:names-by-addr/post.test.js

+  return { txhash, code, height, gas_used };
+};
+
+// XXX overlaps with passCoreEvalProposal from synthetic chain


why not use it?
https://github.com/Agoric/agoric-3-proposals/blob/6e5fec521b33a3479ba9a6fd198b9313f49c5a7f/packages/synthetic-chain/src/lib/core-eval.ts#L86-L89

hm... the reason has faded. something about staticConfig? I'll have to look again.

turadg · 2024-01-26T21:52:17Z

a3p-integration/proposals/c:names-by-addr/test.sh

+#!/bin/bash
+source /usr/src/upgrade-test-scripts/env_setup.sh
+
+yarn ava


glad see no file specified

turadg · 2024-01-26T21:53:01Z

packages/vats/test/bootstrapTests/test-demo-config.js

@@ -67,6 +67,16 @@ test('sim/demo config provides home with .myAddressNameAdmin', async t => {
  keyArrayEqual(t, keys(home).sort(), homeKeys);
 });

+test('namesByAddress contains provisioned account', async t => {


good thinking including here too

dckc · 2024-02-15T04:50:23Z

overtaken by stuff such as ##8901

dckc changed the base branch from master to release-mainnet1B January 22, 2024 18:37

dckc mentioned this pull request Jan 22, 2024

feat(names-by-addr): test provisioning vat upgrade Agoric/agoric-3-proposals#76

Closed

dckc mentioned this pull request Jan 23, 2024

how to grant limited authority to save contract upgrade materials? #8378

Open

dckc force-pushed the 8113-namesByAddr-release branch from c3d7a60 to 2d9b00c Compare January 23, 2024 01:16

dckc changed the base branch from release-mainnet1B to tmp-release-provisioning January 23, 2024 01:17

dckc force-pushed the 8113-namesByAddr-release branch from 2d9b00c to 0b3d941 Compare January 25, 2024 23:31

fix(provisioning): don't use disconnected namesByAddress

a0ac6d9

`namesByAddress` supplied by the provisioning vat was an independent NameHub from `namesByAddressAdmin`.

dckc force-pushed the 8113-namesByAddr-release branch from 6855580 to 6999bff Compare January 26, 2024 03:02

dckc mentioned this pull request Jan 26, 2024

port "add a CoreEval to a3p-integration" to release branch (WIP) #8819

Closed

dckc changed the base branch from tmp-release-provisioning to dc-a3p-15 January 26, 2024 03:08

dckc force-pushed the 8113-namesByAddr-release branch from 6999bff to 7286ca1 Compare January 26, 2024 03:17

dckc mentioned this pull request Jan 26, 2024

fix(provisioning): export useful namesByAddress #8821

Merged

test: namesByAddress contains provisioned account

1678b6b

dckc force-pushed the 8113-namesByAddr-release branch from 7286ca1 to 3d4e9af Compare January 26, 2024 03:49

dckc added 3 commits January 26, 2024 00:04

feat: upgrade proposal to fix namesByAddress in provisioning vat

c262472

test: send invitation via (upgraded) namesByAddress

814be1a

- run core-eval to replace provisioning vat - test incarnation - functional test

build: lock packages

e5a2c17

dckc force-pushed the 8113-namesByAddr-release branch from 3d4e9af to e5a2c17 Compare January 26, 2024 06:05

dckc requested review from turadg and mhofman January 26, 2024 06:07

dckc changed the title ~~fix(provisioning): export useful namesByAddress~~ fix(provisioning): export useful namesByAddress (release branch) Jan 26, 2024

This was referenced Jan 26, 2024

can't send to account by address: namesByAddress is empty #8113

Closed

can't build bundles compatible with mainnet due to endo patterns breaking change #8826

Closed

turadg reviewed Jan 26, 2024

View reviewed changes

This was referenced Feb 12, 2024

build ESM dist for npm package Agoric/agoric-3-proposals#102

Merged

feat(cosmos): upgrade provisioning vat #8901

Merged

dckc closed this Feb 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(provisioning): export useful namesByAddress (release branch) #8786

fix(provisioning): export useful namesByAddress (release branch) #8786

dckc commented Jan 22, 2024 •

edited

Loading

dckc commented Jan 22, 2024

dckc commented Jan 23, 2024

dckc commented Jan 26, 2024

turadg Jan 26, 2024

dckc Jan 27, 2024

turadg Jan 26, 2024

turadg Jan 26, 2024

dckc commented Feb 15, 2024

fix(provisioning): export useful namesByAddress (release branch) #8786

fix(provisioning): export useful namesByAddress (release branch) #8786

Conversation

dckc commented Jan 22, 2024 • edited Loading

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

dckc commented Jan 22, 2024

dckc commented Jan 23, 2024

dckc commented Jan 26, 2024

turadg Jan 26, 2024

Choose a reason for hiding this comment

dckc Jan 27, 2024

Choose a reason for hiding this comment

turadg Jan 26, 2024

Choose a reason for hiding this comment

turadg Jan 26, 2024

Choose a reason for hiding this comment

dckc commented Feb 15, 2024

dckc commented Jan 22, 2024 •

edited

Loading