feat(cosmos): upgrade provisioning vat #8901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
changed the title
|
FYI @dckc |
mhofman
force-pushed
the
mhofman/8887-fix-governance
branch
from
47be563
to
229b36f
Compare
mhofman
force-pushed
the
mhofman/provisioning-upgrade
branch
from
915fea9
to
ef6ffcb
Compare
dckc
approved these changes
Feb 13, 2024
| @@ -0,0 +1,53 @@ | |||
| // @ts-check | |||
There was a problem hiding this comment.
hm. another copy of this file? we can't get the relevant stuff from the synthetic chain package?
There was a problem hiding this comment.
If there's a way, I'm open to it. I just extracted what you had in #8786. I'm open to alternatives!
There was a problem hiding this comment.
I think I found a way. PTAL
Comment on lines
+852
to
+853
| // Then, upgrade the provisioning vat | ||
| vm.CoreProposalStepForModules("@agoric/builders/scripts/vats/replace-provisioning.js"), |
There was a problem hiding this comment.
this is more than a test... ah... the commit message says feat. The PR title threw me off a bit.
| @@ -335,6 +335,16 @@ __metadata: | |||
| languageName: node | |||
| linkType: hard | |||
|
|
|||
| "brace-expansion@npm:^1.1.7": | |||
There was a problem hiding this comment.
all these changes to yarn.lock come from adding tmp?
I guess this is not our main yarn.lock, so there's not much supply-chain risks.
|
I will likely extract the core-eval-support part into a separate stand alone PR so that #8909 can stand on it too. |
mhofman
changed the title
mhofman
force-pushed
the
mhofman/provisioning-upgrade
branch
from
9e9f2da
to
031343d
Compare
|
Ran into a synthetic-chain bug: Agoric/agoric-3-proposals#104 |
This was referenced Feb 15, 2024
mhofman
added
force:integration
mhofman
force-pushed
the
mhofman/provisioning-upgrade
branch
from
77bad99
to
19ee116
Compare
mhofman
added
automerge:squash
mhofman
force-pushed
the
mhofman/provisioning-upgrade
branch
2 times, most recently
from
eba0d8b
to
6316acf
Compare
mhofman
force-pushed
the
mhofman/provisioning-upgrade
branch
from
6316acf
to
af72df2
Compare
mhofman
force-pushed
the
mhofman/provisioning-upgrade
branch
4 times, most recently
from
84e7127
to
9b526d3
Compare
mhofman
force-pushed
the
mhofman/provisioning-upgrade
branch
from
9b526d3
to
fede847
Compare
mhofman
added
automerge:squash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #8821 #8311 #8786
closes: #8113
Stacked on #8902
Description
Core proposal to upgrade the provisioning vat (follow-up from #8821) and a3p integration test to verify namesByAddress works as expected (adapted from #8786)
Security Considerations
Same as #8821
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
Adds a3p integration test
Upgrade Considerations
Core proposal to be executed during chain software upgrade. Tested in a3p. Has equivalent PR on the release branch.