test: verify purse balances are updated after smartWallet upgrade #8909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
reviewed
Feb 13, 2024
Comment on lines
2
to
12
| "agoricProposal": { | ||
| "releaseNotes": "TBD", | ||
| "sdkImageTag": "unreleased", | ||
| "planName": "UNRELEASED_UPGRADE", | ||
| "upgradeInfo": { | ||
| "coreProposals": [ | ||
| "@agoric/builders/scripts/vats/init-network.js" | ||
| ] | ||
| }, | ||
| "type": "Software Upgrade Proposal" | ||
| }, |
There was a problem hiding this comment.
Why is this a 2nd chain software upgrade? it should be in the existing a:upgrade-next on master.
a3p-integration/proposals/b:upgrade-14/invite-submission/README.md
Outdated
Show resolved
Hide resolved
Chris-Hibbert
force-pushed
the
8445-a3p-tests-mastr
branch
from
b04cd4f
to
0429a58
Compare
Chris-Hibbert
commented
Feb 13, 2024
a3p-integration/proposals/b:upgrade-14/invite-submission/README.md
Outdated
Show resolved
Hide resolved
Comment on lines
2
to
12
| "agoricProposal": { | ||
| "releaseNotes": "TBD", | ||
| "sdkImageTag": "unreleased", | ||
| "planName": "UNRELEASED_UPGRADE", | ||
| "upgradeInfo": { | ||
| "coreProposals": [ | ||
| "@agoric/builders/scripts/vats/init-network.js" | ||
| ] | ||
| }, | ||
| "type": "Software Upgrade Proposal" | ||
| }, |
turadg
approved these changes
Feb 13, 2024
Chris-Hibbert
force-pushed
the
8445-a3p-tests-mastr
branch
from
0429a58
to
5298932
Compare
mhofman
changed the title
|
@Chris-Hibbert I adapted the test to match the new style and helpers for core-eval in tests. Will squash-merge if you're of with the latest state |
mhofman
added a commit
that referenced
this pull request
Feb 18, 2024
) * test: verify purse balances are updated after smartWallet upgrade * chore: helpful suggestions from review * refactor: testRepairs to Ava test * chore: make test work on master * chore: rearrange files, repair merge conflict * chore: rename * chore: adapt wallet a3p test to new core-eval style * fixup --------- Co-authored-by: Turadg Aleahmad <turadg@agoric.com> Co-authored-by: Mathieu Hofman <mathieu@agoric.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #8787
Description
A copy of #8787 for master.
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing/Upgrade Considerations