test: verify purse balances are updated after smartWallet upgrade #8787

Chris-Hibbert · 2024-01-22T21:21:11Z

closes: #8293

Description

Verify that purse balances are updated after smartWallet upgrade in an a3p-integration test.

Security Considerations

None.

Scaling Considerations

None

Documentation Considerations

None

Testing/Upgrade Considerations

This is a test that upgrading SmartWallet maintains the ability to update vstorage for purses.

turadg

Some

turadg · 2024-01-25T22:21:53Z

a3p-integration/proposals/b:wallet-factory2/package.json

+    "type": "module",
+    "license": "Apache-2.0",
+    "dependencies": {
+        "@agoric/synthetic-chain": "^0.0.3",


if you use 0.0.4-2 then you don't need core-eval-support.js and most of performActions.js.

you'll still need eval.sh because you're making an extra submission distinct from the agoricProposal one.

core-eval-support.js is gone, but I couldn't find definitions of anything in performActions in @synthetic-chain. How/where should I have searched?

3836e70a takes us back to 0.0.3, so I'm going to assume for now that the suggestions about reducing performActions.js won't apply until a later branch.

a3p-integration/proposals/b:wallet-factory2/package.json

a3p-integration/proposals/b:wallet-factory2/submission/sendInvite-permit.json

turadg

No blockers, but the code can be simpler to reduce maintenance cost and be a better example

turadg · 2024-01-25T23:22:27Z

a3p-integration/proposals/b:wallet-factory2/performActions.ts

+/** Provide access to the outside world via context. */
+const makeTestContext = async () => {
+  // assume filenames don't overlap
+  const bundleAssets = makeFakeWebCache('submission');


if you're going to keep this part of performActions.ts then consider renaming the submission directory and this string that's looking for it.

But I think you could simplify this file to,

import { evalBundles } from '@agoric/synthetic-chain/src/lib/core-eval.js`; evalBundles('zcfProber-submission');

Oh, I guess there's already support for specifying a directory path. 🤦

I reran yarn; yarn build, but I still don't see '@agoric/synthetic-chain/src/lib/core-eval.js';. I looked in a3p as well, and it doesn't appear to be in packages/synthetic-chain/src/lib, and I've just pulled again.

Chris-Hibbert · 2024-01-26T00:03:47Z

Sorry, I asked for a re-review, but I hadn't submitted my comments. Apologies.

Chris-Hibbert

I moved the proposal from ./submission to ./invite-submission.

Chris-Hibbert · 2024-01-26T18:41:39Z

a3p-integration/proposals/b:wallet-factory2/package.json

+    "type": "module",
+    "license": "Apache-2.0",
+    "dependencies": {
+        "@agoric/synthetic-chain": "^0.0.3",


3836e70a takes us back to 0.0.3, so I'm going to assume for now that the suggestions about reducing performActions.js won't apply until a later branch.

mhofman

Why is this a new layer? Why are the tests not added to the chain software upgrade layer which already performs the wallet factory upgrade as a core proposal?

turadg · 2024-01-26T22:55:56Z

a3p-integration/proposals/a:upgrade-14/invite-submission/README.md

+The main core-eval submission here is the wallet upgrade, which is specified in
+package.json and built in ./submission.


not true anymore but not a blocker.

The wallet upgrade is part of the upgrade-14 "upgradeInfo"

turadg · 2024-01-26T22:56:10Z

a3p-integration/proposals/a:upgrade-14/invite-submission/README.md

+The core-eval is invoked from the test, which then verifies that the details are
+written to vstore.
+
+https://github.com/Agoric/agoric-3-proposals/issues/82 will provide a better way


lots of room for improvement :)

mhofman

LGTM besides the unexplained logging change to the smart wallet

mhofman · 2024-02-09T15:19:17Z

a3p-integration/proposals/a:upgrade-14/invite-submission/README.md

@@ -0,0 +1,12 @@
+This core-eval installs upgrades for the wallet and Zoe. This test verifies that


Probably should remove the first sentence since the wallet factory and zoe upgrades are part of the chain software upgrade now.

Please revise the whole readme. I think it was moved from a README for the earlier governance proposal but now it's scoped to just this core-eval used for testRepairs

Here's another attempt.

These files enable a test of the walletFactory changes in upgrade-14, by verifying that upgraded wallets that aren't backed by vbanks can still add assets, in this case an invitation.

mhofman · 2024-02-09T15:22:23Z

a3p-integration/proposals/a:upgrade-14/invite-submission/README.md

+(sendInvite.tpl) to produce the .js file that will be submitted.
+
+The core-eval is invoked from the test, which then verifies that the details
+were written to vstore.


Suggested change

were written to vstore.

were written to vstorage.

mhofman · 2024-02-09T15:26:24Z

a3p-integration/proposals/a:upgrade-14/testRepairs.ts

+const replaceAddressInFile = async (string, fileName, replacement) => {
+  const scriptBuffer = await readFile(`${SUBMISSION_DIR}/${fileName}.tpl`);


Nit: the order of arguments is surprising. Also why hard code SUBMISSION_DIR instead of expecting it in the input fileName?

good suggestions.

mhofman · 2024-02-09T15:28:39Z

packages/smart-wallet/src/smartWallet.js

-          trace(`Found ${brandToPurses.values()} purse(s) for ${address}`);
+          trace(`Found purse(s) for ${address}`);


Is this change to debug logging in the smart wallet meant to go into a "testing" PR?

It's also a change I don't see on master.

please revert

Chris-Hibbert · 2024-02-09T17:04:29Z

I simplified testRepairs.ts substantially (and dropped all the added dependencies) after getting it to work cross-platform. It's worth another look.

integration cleanup

add a CoreEval proposal to a3p-integration

Re-add a CoreEval proposal to a3p-integration

Clarify a3p-integration

* feat(a3p-integration): add core eval in test * fixup! feat(a3p-integration): add core eval in test * Nudge * test: reduce race sensitivity --------- Co-authored-by: Turadg Aleahmad <turadg@agoric.com>

) * test: verify purse balances are updated after smartWallet upgrade * chore: helpful suggestions from review * refactor: testRepairs to Ava test * chore: make test work on master * chore: rearrange files, repair merge conflict * chore: rename * chore: adapt wallet a3p test to new core-eval style * fixup --------- Co-authored-by: Turadg Aleahmad <turadg@agoric.com> Co-authored-by: Mathieu Hofman <mathieu@agoric.com>

mhofman · 2024-02-18T03:48:37Z

I re-synced this PR with #8909 and stacked it on #8942

Chris-Hibbert added wallet contract-upgrade labels Jan 22, 2024

Chris-Hibbert self-assigned this Jan 22, 2024

mhofman mentioned this pull request Jan 24, 2024

smartWallet stops updating purse balance on upgrade #8293

Closed

7 tasks

Chris-Hibbert requested a review from turadg January 25, 2024 21:40

turadg mentioned this pull request Jan 25, 2024

support for installing proposals as part of test Agoric/agoric-3-proposals#82

Open

turadg reviewed Jan 25, 2024

View reviewed changes

Chris-Hibbert requested a review from turadg January 25, 2024 23:06

turadg approved these changes Jan 25, 2024

View reviewed changes

Chris-Hibbert commented Jan 26, 2024

View reviewed changes

Chris-Hibbert force-pushed the 8445-a3p-tests branch from c1f32d9 to 4ce0658 Compare January 26, 2024 22:19

mhofman requested changes Jan 26, 2024

View reviewed changes

turadg force-pushed the 8445-a3p-tests branch from 3e13f5b to 71a2b39 Compare January 26, 2024 22:42

mhofman approved these changes Jan 26, 2024

View reviewed changes

mhofman added the force:integration Force integration tests to run on PR label Jan 26, 2024

turadg approved these changes Jan 26, 2024

View reviewed changes

Chris-Hibbert force-pushed the 8445-a3p-tests branch 7 times, most recently from 77dc118 to 5e98f9f Compare January 31, 2024 22:36

Chris-Hibbert force-pushed the 8445-a3p-tests branch 2 times, most recently from 929c333 to 0be12d4 Compare February 9, 2024 01:32

test: verify purse balances are updated after smartWallet upgrade

d06b176

Chris-Hibbert force-pushed the 8445-a3p-tests branch from 0be12d4 to d06b176 Compare February 9, 2024 01:34

mhofman approved these changes Feb 9, 2024

View reviewed changes

turadg and others added 16 commits February 18, 2024 01:11

ci: delete disabled dapp-fungible-faucet test

9b8632f

ci: merge integration branch before endo checkout (#8892)

432119c

docs(a3p): UPGRADE NEEDED case

a771135

Merge pull request #8899 from Agoric/ta/integration-cleanup

f604f36

integration cleanup

ci: build sdk in upgrade test for potential proposal uses

50bda55

chore(deps): simplify a3p-integration package

9b97c03

chore(a3p): bump synthetic-chain to 0.0.6-4

d1a6683

test(a3p): restart vats

448b5e6

Merge pull request #8801 from Agoric/ta/a3p-coreeval

a573d6f

add a CoreEval proposal to a3p-integration

fix(a3p-integration): rebuild SDK image automatically

d281be6

Merge pull request #8907 from Agoric/mhofman/reland-8801

78e6d4c

Re-add a CoreEval proposal to a3p-integration

fixup! fix(a3p-integration): rebuild SDK image automatically

2798b83

docs: detail structure of a3p-integration

2a479eb

Merge pull request #8886 from Agoric/mhofman/clarify-a3p

6fdb83f

Clarify a3p-integration

feat(a3p-integration): add core eval in test (#8929)

aa952b4

* feat(a3p-integration): add core eval in test * fixup! feat(a3p-integration): add core eval in test * Nudge * test: reduce race sensitivity --------- Co-authored-by: Turadg Aleahmad <turadg@agoric.com>

fix(a3p): serial test execution (#8940)

0b2a8a3

mhofman changed the base branch from dev-upgrade-14 to mhofman/cherry-pick-ibc-updates February 18, 2024 03:32

Merge branch 'mhofman/cherry-pick-a3p-changes' into 8445-a3p-tests

f6a24a1

mhofman changed the base branch from mhofman/cherry-pick-ibc-updates to mhofman/cherry-pick-a3p-changes February 18, 2024 03:36

Chris-Hibbert and others added 2 commits February 18, 2024 03:41

chore: rename

4662b58

mhofman force-pushed the mhofman/cherry-pick-a3p-changes branch 2 times, most recently from 44ae7cc to 6d9459d Compare February 19, 2024 21:17

Base automatically changed from mhofman/cherry-pick-a3p-changes to dev-upgrade-14 February 19, 2024 22:40

Merge branch 'dev-upgrade-14' into 8445-a3p-tests

4c3ecaa

mhofman merged commit 46f957f into dev-upgrade-14 Feb 19, 2024
64 checks passed

mhofman deleted the 8445-a3p-tests branch February 19, 2024 23:16

This was referenced Feb 20, 2024

chore(release): publish upgrade-14 #8959

Closed

chore(release): publish upgrade-14 #9003

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: verify purse balances are updated after smartWallet upgrade #8787

test: verify purse balances are updated after smartWallet upgrade #8787

Chris-Hibbert commented Jan 22, 2024

turadg left a comment

turadg Jan 25, 2024

Chris-Hibbert Jan 25, 2024

Chris-Hibbert Jan 26, 2024

turadg left a comment

turadg Jan 25, 2024

Chris-Hibbert Jan 26, 2024 •

edited

Loading

Chris-Hibbert commented Jan 26, 2024

Chris-Hibbert left a comment

Chris-Hibbert Jan 26, 2024

mhofman left a comment

turadg Jan 26, 2024

turadg Jan 26, 2024

mhofman left a comment

mhofman Feb 9, 2024

turadg Feb 9, 2024

Chris-Hibbert Feb 9, 2024

mhofman Feb 9, 2024

mhofman Feb 9, 2024

Chris-Hibbert Feb 9, 2024

mhofman Feb 9, 2024

turadg Feb 9, 2024

Chris-Hibbert Feb 9, 2024

Chris-Hibbert commented Feb 9, 2024

mhofman commented Feb 18, 2024

		The main core-eval submission here is the wallet upgrade, which is specified in
		package.json and built in ./submission.

		@@ -0,0 +1,12 @@
		This core-eval installs upgrades for the wallet and Zoe. This test verifies that

		const replaceAddressInFile = async (string, fileName, replacement) => {
		const scriptBuffer = await readFile(`${SUBMISSION_DIR}/${fileName}.tpl`);

		trace(`Found ${brandToPurses.values()} purse(s) for ${address}`);
		trace(`Found purse(s) for ${address}`);

test: verify purse balances are updated after smartWallet upgrade #8787

test: verify purse balances are updated after smartWallet upgrade #8787

Conversation

Chris-Hibbert commented Jan 22, 2024

Description

Security Considerations

Scaling Considerations

Documentation Considerations

Testing/Upgrade Considerations

turadg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

turadg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Chris-Hibbert Jan 26, 2024 • edited Loading

Choose a reason for hiding this comment

Chris-Hibbert commented Jan 26, 2024

Chris-Hibbert left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mhofman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mhofman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Chris-Hibbert commented Feb 9, 2024

mhofman commented Feb 18, 2024

Chris-Hibbert Jan 26, 2024 •

edited

Loading