Cherry-pick upgrade-14 cosmos changes #8869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JimLarson are the golint failures expected? |
mhofman
force-pushed
the
mhofman/cherry-pick-ibc-updates
branch
from
04db7e9
to
5c0ff3c
Compare
|
Yes, the golint failures are expected. See #8866 for a fix from @michaelfig . |
|
See also #8803 for a cleanup of the deprecated APIs. |
|
Getting the following error in the integration test: It sounds like one of the 2 validator nodes crashed, the chain stopped producing blocks, so when the light client tried to verify the block after the snapshot, it failed because that block didn't exist. Will try to look into the validator node logs to see why it crashed. |
|
Yup as I expected, panic while creating the snapshot. Stack validator1It looks very similar to #8047. Good news is that it's not a new issue, I was probably unlucky to trigger it. Bad news is that the new ibc / cosmos stack does not fix it. |
|
I am holding this until we solve #8871 |
|
I'm seeing a lot of divergence between this PR and my local attempt to recreate it by following the rebase-todo. Did you miss a chunk of picks? |
I have merged some other PRs into |
Allows it to access some internal struct fields.
This was a replace directive in the cosmos-sdk go.mod file, hence not automatically propagaged.
Fix for MacOS Sonoma Ledger detection issues
feat(cosmos): Add a "CapData" vstorage RPC endpoint
chore(cosmos): Update doc comments for accuracy
docs(cosmos/x/vstorage): Add REAME link to vstorage/query.proto
docs(cosmos/x/vstorage): Add README sections for CLI and "REST" API interfaces
…-example docs(vstorage): Add an example external protobuf interface interaction
cf. https://pkg.go.dev/github.com/spf13/cobra#Command and https://github.com/spf13/cobra/blob/v1.8.0/site/content/user_guide.md#example Only optional arguments should be wrapped in square brackets, alternatives should be wrapped in curly braces, and `Long` strings should generally start similar to `Use`.
feat: agd query vstorage trailing slash for children
Replace panics with friendly error messages.
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
style(golang): Align CLI command fields with upstream recommendations
docs(golang): Improve the description of PopulateAction
gibson042
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Selected changes look reasonable and the rebase-todo corresponds with final state modulo the edit lines1. LGTM 👍
Footnotes
-
side note: I wonder if we could eliminate both those and the handful of merge conflicts by means of
execlines to insert novel patches in the stream, but would only want to pursue that if we think this overall pattern will endure. ↩
Interesting idea, but hopefully we don't need to do this much longer. |
This was referenced Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are almost all the changes to
golang/cosmosinto upgrade-14. Most notably, the core of the split-vm work is still excluded, but its context changes are included, which causes some conflict resolution in a few places.Compare
golang/cosmosfrom this branch with master: master...mhofman/cherry-pick-ibc-updatesConstructed from the following rebase-todo:
Security Considerations
None specific to this cherry-pick
Scaling Considerations
None specific to the cherry-pick
Documentation Considerations
Release info should make a mention of this notable change
Testing Considerations
TBD @JimLarson
Core eval logic tested in #8942
Upgrade Considerations
Chain software change deployed as part of chain software upgrade