more robust repairWalletForIncarnation2 #8966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
approved these changes
Feb 23, 2024
mhofman
reviewed
Feb 24, 2024
Comment on lines
+648
to
+652
| let invitationAmount = state.offerToUsedInvitation.get( | ||
| // @ts-expect-error older type allowed number | ||
| offerSpec.id, | ||
| ); | ||
| if (invitationAmount) { |
There was a problem hiding this comment.
This will throw if the key doesn't exist. It needs to be a .has check instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In testing with production state we noticed new log messages that hadn't appeared in synthetic tests. And the investigation of making invitations revealed that they were never burned.
This addresses those by:
repairWalletForIncarnation2It also includes some type coverage improvements made while navigating the code above.
Security Considerations
none
Scaling Considerations
Prevents some wasted retention of unused invitations
Documentation Considerations
n/a
Testing Considerations
we should see the new log messages in upgrade-14 testing
Upgrade Considerations
To be included in
dev-upgrade-14cc @mhofman