fix: repair incorrect fix for repairWalletForIncarnation2 #8984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
Feb 24, 2024
|
A test that would have caught this would be nice, but this is a one off execution and our testing process is covering it. |
Chris-Hibbert
force-pushed
the
8966-repair
branch
from
7dabb8b to
4d6a823
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #8966
Description
@mhofman noticed a problem in #8966. This is intended to fix it.
Security Considerations
We're attempting to repair things on chain. If the repair fails, it could affect the chain's integrity.
Scaling Considerations
N/A
Documentation Considerations
None
Testing Considerations
We'll be testing in mainfork.
Upgrade Considerations
It's all about upgrade.